Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent controlled layout #3

Open
souporserious opened this issue Dec 22, 2020 · 4 comments
Open

Parent controlled layout #3

souporserious opened this issue Dec 22, 2020 · 4 comments
Labels
design decision How -should- it work?

Comments

@souporserious
Copy link

Right now Text/Heading can set their own spacing (padding/margin), should this only be a responsibility of Box and possibly other future layout components like Grid and Flex to help make composition easier?

@StephenHaney
Copy link
Contributor

Great topic... I think that makes a lot of sense. Please keep these thoughts coming!

@naher94
Copy link

naher94 commented Dec 22, 2020

@souporserious that's interesting, but I guess if the goal is the mirror HTML and CSS then it makes sense for text to carry padding and margin.... @StephenHaney Question for you would be is the idea to expose the underlying technology's philosophy to the end user or hid it away? I have thoughts on this as tools designer myself but I'll hold it to see what Modulz direction is

@StephenHaney
Copy link
Contributor

There's definitely a balance to find. We have an opinion but I think it will be driven by user feedback too.

In a perfect world, I'd like things to be approachable for non-coders, but not lose any of the power of html/css if you want to drop down and dial things in.

What were you thinking @naher94?

@naher94
Copy link

naher94 commented Dec 23, 2020

I would agree it should definitely be approachable for non-devs and only then you can start to uncover or share the more technical/underlying technology with the user. You could enhance the clarity of the item for those more "power user" types with some kind of hover over state that share a bit more about what a <div> is for example. Something like this might be nice. Mock up for illustrative purposes of course.

Related though:
I think the term Box is a bit confusing since it could be read as rectangle or div and in this instance it's a div from what I see. I wonder if Container would be a better term for both dev and non-dev minds alike, following the need to make the tool accessible but also showcasing the power of html/css.

Frame 1

@StephenHaney StephenHaney added the design decision How -should- it work? label Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design decision How -should- it work?
Projects
None yet
Development

No branches or pull requests

3 participants