Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep original data_deps while resolving graph #148

Open
changhai0109 opened this issue Aug 20, 2024 · 0 comments · May be fixed by #149
Open

keep original data_deps while resolving graph #148

changhai0109 opened this issue Aug 20, 2024 · 0 comments · May be fixed by #149
Assignees
Labels
enhancement New feature or request

Comments

@changhai0109
Copy link
Contributor

Problem Related to the Feature

One of the future works on astrasim about memory requires getting the original data dependency from the workload.
However, in the current implementation of ETFeeder the original data_deps will be mutated for recording dependency resolving.

Proposed Solution

Instead of directly mutating the data_deps in proto object, create another dependency list in the ETFeederNode or ETFeeder called unresolved_data_deps, which is mutatable and used to track the dependency resolving.

I will push a PR later to fix this issue.

@changhai0109 changhai0109 added the enhancement New feature or request label Aug 20, 2024
@changhai0109 changhai0109 self-assigned this Aug 20, 2024
@changhai0109 changhai0109 linked a pull request Aug 20, 2024 that will close this issue
@changhai0109 changhai0109 linked a pull request Aug 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant