Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong return type in librispeech model_fn #762

Open
Niccolo-Ajroldi opened this issue May 9, 2024 · 0 comments
Open

Wrong return type in librispeech model_fn #762

Niccolo-Ajroldi opened this issue May 9, 2024 · 0 comments

Comments

@Niccolo-Ajroldi
Copy link
Contributor

Niccolo-Ajroldi commented May 9, 2024

In librispeech_conformer the model_fn returns logits_batch as a Tuple of tensors, not a tensor.

The return type is hence wrong:

update_batch_norm: bool) -> Tuple[spec.Tensor, spec.ModelAuxiliaryState]:

It should be:

  def model_fn(...) -> Tuple[Tuple[spec.Tensor, spec.Tensor], spec.ModelAuxiliaryState]:

As insignificant as it seems, this caused me quite some trouble debugging an OOM issue. Might be useful for other ppl too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant