Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code lines potentially cited incorrectly for EMBRYO state change in allocproc #11

Open
dareonion opened this issue Mar 9, 2019 · 0 comments
Open

code lines potentially cited incorrectly for EMBRYO state change in allocproc #11

dareonion opened this issue Mar 9, 2019 · 0 comments

Comments

@dareonion
Copy link

error_in_embryo_code_line_numbers

Here the code lines pointed out after "unique pid" seem a little off from what's intended. My guess is that the intention was to specify (2488-2489), but due to the occurrence of EMBRYO in the comments preceding the allocproc function, the regex matched the wrong EMBRYO. Not sure what your favorite fix would be, but seems like it should be a pretty easy fix.

xv6-book/first.t

Line 534 in 3cb96cf

.lines proc.c:/EMBRYO/,/nextpid/ .

tzerbib added a commit to tzerbib/xv6-book that referenced this issue Jul 5, 2019
@tzerbib
Close mit-pdos#11
55912e2
@tzerbib tzerbib mentioned this issue Jul 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dareonion