Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Invalid syntax highlighting #160713

Closed
ErnstStavroBlofeld opened this issue Sep 12, 2022 · 3 comments
Closed

PHP Invalid syntax highlighting #160713

ErnstStavroBlofeld opened this issue Sep 12, 2022 · 3 comments
Assignees
@roblourens
Labels
php PHP support issues upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@ErnstStavroBlofeld
Copy link

ErnstStavroBlofeld commented Sep 12, 2022 •
edited
Loading

Type: Bug

Bugs:

  • No support for generics array<int, string>
  • No support for meta-types class-string or class-string<ArrayAccessible>
  • No support for:
    • @teplate
    • @implements
    • @extends
  • Namespace \App\My\Class will have portion \App\My\ inherit comment color and Class actually properly colored (support.class.php - meta.other.type.phpdoc.php)

VS Code version: Code 1.71.0 (Universal) (784b017, 2022-09-01T07:25:38.437Z)
OS version: Darwin arm64 21.6.0
Modes:
Sandboxed: No
@ErnstStavroBlofeld
Copy link
Author

Example 1 - generics

image

@ErnstStavroBlofeld
Copy link
Author

Example 2 - namespaces

image

@roblourens roblourens mentioned this issue Sep 14, 2022
Open
@roblourens
Copy link
Member

Filed upstream atom/language-php#461

@roblourens roblourens added php PHP support issues upstream-issue-linked This is an upstream issue that has been reported upstream labels Sep 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
php PHP support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @ErnstStavroBlofeld