Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_pickle_and_log_artifact doesn't clean up pickle file after logging it as an artifact #1353

Open
harupy opened this issue Sep 19, 2024 · 3 comments · May be fixed by #1354
Open

_pickle_and_log_artifact doesn't clean up pickle file after logging it as an artifact #1353

harupy opened this issue Sep 19, 2024 · 3 comments · May be fixed by #1354

Comments

@harupy
Copy link

harupy commented Sep 19, 2024

This line doesn't seem to clean up the pickle file after logging it as an mlflow artifact.

self._pickle_and_log_artifact(automl.feature_transformer, "feature_transformer", "feature_transformer.pkl")

This broke our CI (which doesn't allow untracked files being create during test):

https://github.com/mlflow/mlflow/actions/runs/10933548130/job/30352200311

Untracked files found:
feature_transformer.pkl
label_transformer.pkl
@harupy harupy changed the title _pickle_and_log_artifact doesn't clean up files _pickle_and_log_artifact doesn't clean up pickle file after logging it as an artifact Sep 19, 2024
@harupy
Copy link
Author

harupy commented Sep 19, 2024

I think a temporary directory/file should be used.

@thinkall thinkall linked a pull request Sep 19, 2024 that will close this issue
4 tasks
@thinkall
Copy link
Collaborator

Hi @harupy , thanks for reporting the issue. Would removing the artifact source file after logging work for you?

@harupy
Copy link
Author

harupy commented Sep 19, 2024

@thinkall that would work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants