Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure to not remove i elements or modify them to em when using for icons e.g. css classes are present. #13

Open
LiamKarlMitchell opened this issue Jun 10, 2020 · 0 comments

Comments

@LiamKarlMitchell
Copy link

The i tag is used for icons in the front end WeltPixel Pearl theme for example.

image

Test
<i class="footer-icon icon-line-clock"></i>
Test

Click show editor.
Click hide editor.

image

The html is modified the i tag was removed as part of cleanup because it is "empty".

<p>Test Test</p>

Their theme installs sample data to modify which includes a lot of various tags, which all get wiped when editing.

You can work around it by using an html comment inside the i tag, which works but then the i tag is changed to an em tag. Seems to still work but weird behavior.

Related:
magento/magento2#21602
tinymce/tinymce#2689 (comment)

Additionally, when in WYSIWYG edit, no icon shows but I think that is because admin does not load child theme css. Any workaround for this?

Is there a hook or way to modify the Tiny MCE to not remove such tags?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant