Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests passing even though there are errors #363

Open
x3ro opened this issue Jan 13, 2018 · 1 comment
Open

Functional tests passing even though there are errors #363

x3ro opened this issue Jan 13, 2018 · 1 comment

Comments

@x3ro
Copy link
Contributor

x3ro commented Jan 13, 2018

I noticed that some of the functional tests (I haven't verified if this applies for all) pass even if there are errors during the test execution. This, for example, applies for the spec/registrationJourney.js. To verify this, insert some random string in the scope below

.getText('span.amount')
.then((amount) => {
    adkaflsdflksd // e.g.

The test still passes, even though there is an error. I noticed that this is fixed by replacing .end(done) with .call(done), but am not sure if that is a proper fix.

PS: This occurred with Node v9.4.0. Dependencies installed with npm v5.6.0.

@lplotni
Copy link
Owner

lplotni commented Feb 3, 2018

Good catch 👍 And ❤️ for the detailed and informative description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants