-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Show Clickable Link" checkbox does not update until entire dashboard is saved #3794
Comments
Can I work on it? If you think it's could be good first issue. |
You can work on this. See our contribution guide: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md |
Hi @BBaoVanC How do you recreate the bug? I tried the edit stats page it doesn't really show this checkbox. |
I sent a picture with the steps of reproducing it in a different thread: #3795 (comment). If it's not there, what version are you on? |
Oh @BBaoVanC found it. thanks Also I fixed the issue, should I just make a pull request now? Screen.Recording.2023-11-13.at.10.11.45.PM.movLike this is my first PR, so just wondering,
right? |
I have made a PR. you can see from recording I included in the PR that the issue is fixed. All the tests from auto-check to ESLint. Everything is good. I was wondering if you can merge that. Would be really helpful thanks. |
@Rai-Sahil As I wrote to you via email (sending messages via multiple channels at the same time is not good practice, as it just annoys people ^^):
|
If you want I can change it from the local storage to something else. From the code, I saw that you guys are saving the current state of checkbox in a variable. Even I'm doing the same thing but just storing the value in local storage. Although I tried refreshing the page, I saw no checkbox other than the intended one was checked or not. But I get your point that should be saved in user state. Not that if user closed the browser and re-opens it there. If you want I can come up with some other way as well. |
It seems that this issue is still unfixed, was there a temporary solution to make it take effect? |
Once the entire dashboard is saved, the checkbox updates. |
looks like issue is still unfixed but also temporary solution is not working |
I would like to work upon this if its still open , thank you. |
Shure, go ahead 👍 |
I'll try this issue 👍 |
@CommanderStorm |
🛡️ Security Policy
Description
After checking the "Show Clickable Link" box in a monitor's setting dialog and closing the dialog, reopening the monitor's setting dialog shows the same box still unchecked giving the impression that the setting did not change. Only after saving aving the dashboard and returning to the monitor's setting dialog does the box stay checked.
👟 Reproduction steps
👀 Expected behavior
The checkbox should stay checked to hint that it will be enabled after pressing save on the entire status page
😓 Actual Behavior
The checkbox remains unchecked and the setting seemingly didn't change
🐻 Uptime-Kuma Version
1.23.2
💻 Operating System and Arch
Debian 11
🌐 Browser
Firefox 117.0.1
🐋 Docker Version
Docker 24.0.6
🟩 NodeJS Version
No response
📝 Relevant log output
No response
The text was updated successfully, but these errors were encountered: