Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect expectations for trailing whitespace #411

Open
cmyr opened this issue Mar 7, 2021 · 0 comments
Open

Incorrect expectations for trailing whitespace #411

cmyr opened this issue Mar 7, 2021 · 0 comments
Labels

Comments

@cmyr
Copy link
Member

cmyr commented Mar 7, 2021

expanding on #409 (comment):

I have been misunderstanding the intention of the "trailing whitespace" metric. This should not be about counting any and all whitespace at the end of a line, but rather the range of trailing whitespace that is not relevant for layout. A good heuristic for this is "whitespace the absence of which would not change the drawing of a selection that spans multiple lines".

For our purposes, this should also always include the trailing newline.

I think it's probably worth getting this in for the next piet release, which should be quite imminent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant