Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of pages [#18] [#22] As a user, I can logout #39

Open
wants to merge 9 commits into
base: feature/25-login-page-when-unauthenticated
Choose a base branch
from
Open

[#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of pages [#18] [#22] As a user, I can logout #39

wants to merge 9 commits into from
+301 −22

Conversation

liamstevens111
Copy link
Owner

@liamstevens111 liamstevens111 commented Mar 8, 2023 •
edited
Loading

What happened 👀

  • Changed from passing the User to OutletContext in Private Route to passing the User directly to a Header component from the Private Route
  • Allowed the user to logout by opening a sidebar by clicking on their profile image in the header.
  • Tests - (Still having issues asserting on localstorage mocking calls (this case asserting function called to clear cookie upon logout). It doesnt seem to get called in tests as I think the interceptor will re-direct to login page first.
    Also infinite loop in tests for authenticated route with no user located in private route test with test.skip

Insight 📝

Proof Of Work 📹

Showing the Header on all routes where the user has been authenticated:

Screenshot 2023-03-09 at 16 45 56

Clicking on the User's image displays the sidebar where logout can be performed:

Screenshot 2023-03-13 at 12 12 22

@liamstevens111 liamstevens111 self-assigned this Mar 8, 2023
@netlify
Copy link

netlify bot commented Mar 8, 2023 •
edited
Loading

✅ Deploy Preview for moonlit-buttercream-05cb2f ready!

Name Link
🔨 Latest commit 856692f
🔍 Latest deploy log https://app.netlify.com/sites/moonlit-buttercream-05cb2f/deploys/640856b3e5743c0008c4ee3c
😎 Deploy Preview https://deploy-preview-39--moonlit-buttercream-05cb2f.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023 •
edited
Loading

🚀 Deployed on https://641a75212bce6b323e78956f--moonlit-buttercream-05cb2f.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 8, 2023 09:36 Inactive
@liamstevens111 liamstevens111 changed the base branch from develop to feature/25-login-page-when-unauthenticated March 8, 2023 09:38
@liamstevens111 liamstevens111 mentioned this pull request Mar 8, 2023
Open
5 tasks
@liamstevens111 liamstevens111 changed the title Feature/19 frontend display profile [#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of all pages Mar 8, 2023
@liamstevens111 liamstevens111 changed the title [#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of all pages [#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of pages Mar 8, 2023
@github-actions github-actions bot temporarily deployed to pull request March 9, 2023 02:48 Inactive
@liamstevens111 liamstevens111 force-pushed the feature/19-frontend-display-profile branch from d696e31 to 25f3227 Compare March 9, 2023 02:56
@github-actions github-actions bot temporarily deployed to pull request March 9, 2023 02:58 Inactive
@liamstevens111 liamstevens111 changed the title [#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of pages [#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of pages [#18] [Backend] As a user, I can logout [#22] [UI] As a user, I can logout Mar 9, 2023
@liamstevens111 liamstevens111 force-pushed the feature/19-frontend-display-profile branch from 25f3227 to 997ef75 Compare March 9, 2023 04:24
@github-actions github-actions bot temporarily deployed to pull request March 9, 2023 04:25 Inactive
@liamstevens111 liamstevens111 changed the title [#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of pages [#18] [Backend] As a user, I can logout [#22] [UI] As a user, I can logout [#19] [UI] As a user, when I am authenticated I can see the company logo and my profile image at the top of pages [#18] [#22] As a user, I can logout Mar 9, 2023
@github-actions github-actions bot temporarily deployed to pull request March 13, 2023 05:12 Inactive
@liamstevens111 liamstevens111 force-pushed the feature/19-frontend-display-profile branch from 00771b3 to 0e35d2c Compare March 20, 2023 06:59
@github-actions github-actions bot temporarily deployed to pull request March 20, 2023 07:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2023 10:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 21, 2023 00:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 21, 2023 04:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 21, 2023 04:55 Inactive
@liamstevens111 liamstevens111 force-pushed the feature/19-frontend-display-profile branch from e096f33 to 466ef7f Compare March 21, 2023 05:52
@github-actions github-actions bot temporarily deployed to pull request March 21, 2023 05:53 Inactive
@liamstevens111 liamstevens111 force-pushed the feature/19-frontend-display-profile branch from 466ef7f to 0886516 Compare March 22, 2023 02:07
@github-actions github-actions bot temporarily deployed to pull request March 22, 2023 02:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 22, 2023 03:25 Inactive
@liamstevens111 liamstevens111 marked this pull request as ready for review March 22, 2023 08:34
@liamstevens111 liamstevens111 removed the request for review from hanam1ni March 23, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosle rosle Awaiting requested review from rosle

Assignees

@liamstevens111 liamstevens111

Labels
0.2.0
Projects
None yet
Milestone
No milestone
1 participant
@liamstevens111