Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the new item initial modal make sense? #2201

Closed
webteckie opened this issue Jan 31, 2016 · 10 comments
Closed

Does the new item initial modal make sense? #2201

webteckie opened this issue Jan 31, 2016 · 10 comments

Comments

@webteckie
Copy link
Contributor

Why display an initial modal instead of just displaying the entire form? I have a situation where I have a bunch of list fields that are required and doing this in the initial modal looks a bit ugly. Can we do away with initial and just display the full form?

@jossmac
Copy link
Member

jossmac commented Jan 31, 2016

This is something @twalve and I have been discussing recently, for a current project. Perhaps it could be a feature of autocreate: true?

@webteckie
Copy link
Contributor Author

Never seen that feature but nevertheless it doesn't sound like a natural fit here. What does or would it do? I don't think autocreating will solve it since the user must still input the required values.

@webteckie
Copy link
Contributor Author

@JedWatson does the autocreate: true address this? I have not used that feature and do not see documented either.

@JedWatson
Copy link
Member

autocreate: true is really a different feature, I think. It's for when you can create a new item without any user input (e.g. all required values can be generated)

The create modal exists because not all form fields can be used without an existing item... the form works quite differently in create / edit modes. Might be something we can address down the track though.

@webteckie webteckie added this to the Backlog milestone Mar 6, 2016
@webteckie
Copy link
Contributor Author

Ok moved to backlog for now.

@creynders
Copy link
Contributor

@JedWatson I really think we should move towards dropping the initial modal. It's not so great UX, IMO. And surely the form fields function with a throwaway mongoose document, no? I.e. a new Model w/o saving it to the DB. Or are there fields that look up the old version of the document or something?

@webteckie webteckie changed the title [0.4] Does the new item initial modal make sense? Does the new item initial modal make sense? Apr 2, 2016
@mxstbr
Copy link
Collaborator

mxstbr commented Apr 29, 2016

Now (i.e. after #2566 lands) would be the perfect opportunity to drop this. Do we want to do that @JedWatson?

@creynders
Copy link
Contributor

💯 👍 @JedWatson @mxstbr

@dlindenkreuz
Copy link

Any progress on this?

@gautamsi
Copy link
Member

closing in favor of #1840.
given that Keystone 4 is going in maintenance mode (see #4913 for details). This may or may not land in 4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants