Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxFiles config not working on keystone 5 #226

Open
mmuflih55 opened this issue Jun 25, 2021 · 3 comments
Open

maxFiles config not working on keystone 5 #226

mmuflih55 opened this issue Jun 25, 2021 · 3 comments

Comments

@mmuflih55
Copy link

Bug report

Describe the bug

Cannot change the maxFiles, I think it's because in index.js line 47
const maxFileSize = (this._apollo && this._apollo.maxFileSize) || 200 * 1024 * 1024; const maxFiles = (this._apollo && this._apollo.maxFileSize) || 5;
I think's it's should be
const maxFileSize = (this._apollo && this._apollo.maxFileSize) || 200 * 1024 * 1024; const maxFiles = (this._apollo && this._apollo.maxFiles) || 5;
is it? please Correct me if I'm wrong

To Reproduce

I try to do this at keystone-5 index
new GraphQLApp({ apollo: { config: { maxFiles: 10, }, }, }),

Expected behaviour

Screenshots

Screen Shot 2021-06-25 at 15 44 10

System information

Additional context

  • using keystone 5
    Add any other context about the problem here.
@Martin-Kennedy
Copy link

@mmuflih55 Hi, I am having the same issue. I tried placing some overrides in my project and was not able to get it to work. Have you been able to find a solution to this issue?

@mmuflih55
Copy link
Author

@Martin-Kennedy yes, this solution is working for me...
because I didn't get any response. in the end, I create a temporary plugin fix. (I'm not even change the readme)
and change

const { GraphQLApp } = require('@keystonejs/app-graphql');
to
const { GraphQLApp } = require('temp-ks-app-graphql');

@Martin-Kennedy
Copy link

@mmuflih55 Thanks so much, really appreciate you building out the temp fix module. Worked great!!! Surprised it hasn't been addressed yet since in the discussion regarding keystonjs v5 the announcement stated they would continue with bug fixes and this seems like an obvious bug and a super quick fix... Maybe initiating a PR might make the most sense as it probably just fell off their radar with KS6 out. Either way, thanks again!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants