-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf Audit #1
Comments
I applied some absolute positioning to visually distinguish things with paint flashing on. Okay so the SVG is rasterizing each frame. The DIV only rasterizes at the toggle. Still I think the DIV shouldn't need to rasterize much at all. Curious if we can get rid of that. (That said, the SVG rasterization is whats really important) |
raster costs of the SVGSetting Yup. It's just hitting a lot of rasterization costs on every frame. Damn. using the animation editor is a nice way to diagnose the animation itself. Pause and scrubber dragging totally kick ass: Now, re-reading the project readme. The technique explored in "reverse" is my best guess for what's going have the most promise. Going to move over there. |
Oh |
|
I've exhausted my own techniques on this one. cc @progers @fregu In case you guys are interested in a a well-optimized SVG animation that just isn't good enough. See the readme at https://github.com/kdzwinel/progress-bar-animation for details. Repro:
|
@paulirish this is very problematic with material design spinners when used in an application transition state. Can we expect any improvements here in the medium term? |
@paulirish From what's public, Ganesh appears not to work at all when some SVG is involved:
|
It's not a complete veto for svg. The heuristic is based on the absolute number of non-convex paths. There are two ongoing projects in progress now that will likely remove this heuristic/veto soon. |
Going to dump my notes in here an edit as I go.
Starting with the
master
branch as that seems preferred for ergonomics.Looks like a case of heavy rasterization. SVG gets this a lot.
Let's see what we can do!
The text was updated successfully, but these errors were encountered: