Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper use of STORAGES['sass_processor']['ROOT'] settings for Django >= 4.2 #181

Open
miguelsmatos opened this issue Oct 17, 2024 · 0 comments

Comments

@miguelsmatos
Copy link

Foremost, thank you for making this library available, really appreciate all the work that goes into it.

I seem to have found two issues related with changes made with the setting SASS_PROCESSOR_ROOT for Django>=4.2:

  1. The README.md seems to suggest that the output directory can be configured for Django>=4.2 with STORAGES['sass_processor']['ROOT']. However, looks like we're using STORAGES['sass_processor']['OPTIONS']['ROOT'] in sass_processor/storage.py.
  2. On the same sass_processor/storage.py, the dictionary storage_options=sass_processor_storage.get("OPTIONS") seems to be modified in place; this results in a conflict when SassFileStorage is not a singleton – which it is not – as we pop ROOT. This could be easily fixed by replacing the same line with storage_options = copy.deepcopy(sass_processor_storage.get("OPTIONS") or {}).

I am happy to submit a pull request if you are able to confirm that this is indeed an issue, and which is the design intention for this setting (or its path).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant