Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code link is broken #924

Open
Jean85 opened this issue May 7, 2024 · 9 comments
Open

QR code link is broken #924

Jean85 opened this issue May 7, 2024 · 9 comments

Comments

@Jean85
Copy link
Contributor

Jean85 commented May 7, 2024

The QR code link in the talk page appears to be broken.

I.e, here: https://joind.in/event/phpday-2024/symfony-messenger-the-sharpest-tool-in-your-php-toolbox

The QR-Code (opens in new window) appears to me like this in the browser: QR-Code (opens in new window)

@heiglandreas
Copy link
Member

Looks like the Google Charts API is broken....

@heiglandreas
Copy link
Member

Yeah. Google discontinued QR-code generation via chart.googleapis.com. Instead one should use the nerw charts.google.com. But a search for "QR" does not result in anything....

@Jean85
Copy link
Contributor Author

Jean85 commented May 7, 2024

It seems that the point is that they discontinued the image generation endpoint: https://developers.google.com/chart/image

@heiglandreas
Copy link
Member

heiglandreas commented May 7, 2024

Yeah... Please use www . qr-code-generator . com/ (or some other generator) for now until we found something decent as replacement...

EDIT: See below for a better generator!

Sorry for the inconvenience!

@Jean85
Copy link
Contributor Author

Jean85 commented May 7, 2024

Is https://packagist.org/packages/bacon/bacon-qr-code a possible replacement?

@heiglandreas
Copy link
Member

Could be. But a service that can be used via a get request would definitely be prefered 😁

Yes! We do not need to handle that. And Yes, we are doomed when someone decides to no longer support that 🙈

@Jean85
Copy link
Contributor Author

Jean85 commented May 7, 2024

Roger. As for a temporary workaround, https://forqrcode.com/ is far better, the one you suggested tries to steer you toward signup trial and then forces its short-linking onto you :(

@iansltx
Copy link
Contributor

iansltx commented May 8, 2024

I've used Bacon in the past, and it seems to be actively maintained, so switching to an implementation where we're generating the images seems like a reasonable idea. We can output as a data URI so we don't have to add an endpoint, if that's the hangup.

We'll have to use an older version of the lib for now since we haven't done the PHP 8.x upgrade on this repo yet, but that's fine for the moment.

I'll probably have time between now and Monday to get this implemented with Bacon if someone doesn't beat me to it, with either that implementation or another one.

@iansltx
Copy link
Contributor

iansltx commented May 15, 2024

...and work stuff hit like a sledgehammer. I can maybe take a look at this this weekend, but won't be able to touch it prior to phpDay, though if a PR comes up I can review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants