Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary instability issue #95

Open
martin-oy opened this issue May 31, 2014 · 0 comments
Open

Boundary instability issue #95

martin-oy opened this issue May 31, 2014 · 0 comments

Comments

@martin-oy
Copy link

Hello, I'm trying to implement my own listview extending your lib. I found a problem while testing.
When you drag very slowly near/across boundary at first time, the view becomes unstable and reporting warnings on loading message textview. I found out that you omitted a very tiny condition judging in your codes.
It can be improved by modifying the onScroll() method in line 292 to 293, putting one more condition
if (mRefreshView.getBottom() < mRefreshViewHeight + 20 && mRefreshView.getTop() != 0 && mRefreshState != PULL_TO_REFRESH)
instead of
if (mRefreshView.getBottom() < mRefreshViewHeight + 20 && mRefreshState != PULL_TO_REFRESH)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant