Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project name should be taken from package.json or now.json in priority #138

Open
floo51 opened this issue Jan 16, 2019 · 0 comments
Open

Comments

@floo51
Copy link

floo51 commented Jan 16, 2019

Describe the bug
When deploying, the project name is taken from the directory name.

Now takes the project name from:

  1. now.json
  2. package.json
  3. directory name

To Reproduce

  1. Create a new meteor app in a folder named "bonjour".
  2. Add to package.json:
  "now":{
    "name": "hello",
  }
  1. Deploy
  2. App will deployed to bonjour-xyz.now.sh

Expected behavior

App should be deployed to hello-xyz.now.sh

Additional context

It's especially annoying when willing to do now alias since that takes the name in the package.json, which is not the app name meteor-now used.

Probably around here:

export const projectName = (() => getFolderName(process.cwd()))();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant