Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider calling rendering with current jest.config #80

Open
siebigteroth opened this issue May 6, 2019 · 3 comments
Open

Consider calling rendering with current jest.config #80

siebigteroth opened this issue May 6, 2019 · 3 comments

Comments

@siebigteroth
Copy link

Currently, the configured jest.config isn't considered when creating snapshots. Therefore, e.g. styled-component serializer is ignored, if configured. Issue #30 is similar, but doesn't consider existing configurations.

@siebigteroth siebigteroth changed the title Consider calling jest-diff with current jest.config Consider calling rendering with current jest.config May 6, 2019
@thymikee
Copy link
Member

thymikee commented May 6, 2019

Sounds reasonable. Would you like implementing this change? We could leverage jest-config for that. This would require adding it as a dependency or a peer dependency.
cc @SimenB

@SimenB
Copy link
Member

SimenB commented May 6, 2019

maybe we could somehow pass in the config so you could delegate to other serializers first, then do your diff?

@thymikee
Copy link
Member

thymikee commented Nov 5, 2019

@siebigteroth FYI, we just released v0.6.0 with setSerializers API, which can unblock you: https://github.com/jest-community/snapshot-diff#custom-serializers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants