Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta tags #36

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix meta tags #36

merged 1 commit into from
Sep 16, 2024

Conversation

aramshiva
Copy link
Collaborator

Fix meta tags causing the following error:

Warning: viewport meta tags should not be used in _document.js's <Head>. https://nextjs.org/docs/messages/no-document-viewport-meta

@aramshiva
Fix meta tags
548cd7f 
Fix meta tags causing the following error:
Warning: viewport meta tags should not be used in _document.js's <Head>. https://nextjs.org/docs/messages/no-document-viewport-meta
@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 10:37pm

@aramshiva aramshiva self-assigned this Sep 16, 2024
@aramshiva aramshiva added the enhancement New feature or request label Sep 16, 2024
@jaspermayone
Copy link
Owner

oh i need to fix this on dev too

@jaspermayone
Copy link
Owner

ty

@jaspermayone jaspermayone merged commit 0d917a2 into v2 Sep 16, 2024
4 checks passed
@jaspermayone
Copy link
Owner

oh wait that was dev lol

@jaspermayone
Copy link
Owner

perfect

@jaspermayone jaspermayone deleted the v2-fix2 branch September 16, 2024 22:37
@jaspermayone
Copy link
Owner

next didn't even warn me for some reason @aramshiva

@jaspermayone
Copy link
Owner

wait i think it's only the viewport tag that shouldn't be there @aramshiva

@aramshiva
Copy link
Collaborator Author

aramshiva commented Sep 16, 2024 •
edited
Loading

diddnt realize but it doesn't matter if they other ones are on _app.

@jaspermayone
Copy link
Owner

what's the difference?

@aramshiva
Copy link
Collaborator Author

no difference except the viewport

@jaspermayone
Copy link
Owner

why are there 2 different files then lol

@aramshiva
Copy link
Collaborator Author

aramshiva commented Sep 16, 2024 •
edited
Loading

Ohh, the _app is for the stuff needed to run Next.js related stuff, _document is for everything else

@jaspermayone
Copy link
Owner

Interesting

@jaspermayone
Copy link
Owner

is it worth moving to the new router type?

@jaspermayone
Copy link
Owner

(as a total aside)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspermayone jaspermayone Awaiting requested review from jaspermayone

Assignees

@aramshiva aramshiva

Labels
enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aramshiva @jaspermayone