Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

behavior change in ptable_heatmap_ratio #215

Open
DanielYang59 opened this issue Sep 30, 2024 · 1 comment · May be fixed by #226
Open

behavior change in ptable_heatmap_ratio #215

DanielYang59 opened this issue Sep 30, 2024 · 1 comment · May be fixed by #226
Assignees
@DanielYang59
Labels
matplotlib Concerning matplotlib-powered functions ptable Periodic table

Comments

@DanielYang59
Copy link
Collaborator

DanielYang59 commented Sep 30, 2024 •
edited
Loading

Unexpected behavior change in ptable_heatmap_ratio, some blue tiles (not in 2nd tile) now becomes grey (not in 1nd tile)

ptable-heatmap-ratio

0.10.0 seems to work correctly, but 0.10.1 is broken.
@DanielYang59 DanielYang59 added matplotlib Concerning matplotlib-powered functions ptable Periodic table labels Sep 30, 2024
@DanielYang59 DanielYang59 self-assigned this Sep 30, 2024
@janosh
Copy link
Owner

janosh commented Sep 30, 2024

good thing you noticed! no idea what might have caused this

This was referenced Oct 6, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielYang59 DanielYang59

Labels
matplotlib Concerning matplotlib-powered functions ptable Periodic table
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Breaking] Change default fill_value of count_elements from 0 to None DanielYang59/pymatviz
2 participants
@janosh @DanielYang59