Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPNS helper #4

Open
magik6k opened this issue Oct 29, 2017 · 12 comments
Open

IPNS helper #4

magik6k opened this issue Oct 29, 2017 · 12 comments

Comments

@magik6k
Copy link
Collaborator

magik6k commented Oct 29, 2017

See #3 (comment)

@dirkmc
Copy link
Contributor

dirkmc commented Apr 17, 2018

@magik6k what else needs to be done to get the IPNS helper working?

@magik6k
Copy link
Collaborator Author

magik6k commented Apr 17, 2018

2 most significant things:

@dirkmc
Copy link
Contributor

dirkmc commented Apr 18, 2018

When you say "integrate with keystore nicely" do you mean that when pushing the first time, the IPNS git helper should create a new key in the key store, and associate the unixfs tree with that key in IPNS?

@magik6k
Copy link
Collaborator Author

magik6k commented Apr 18, 2018

maybe not 'associate the unixfs tree', but something like:

git [push/pull] ipns::keystoreKeyName should work. Integrating with dnslinks would be a nice feature too (we'd need to resolve first to see if the dnslink resolves to /ipns name and then see if we have a key for that name in the keystore)

@magik6k
Copy link
Collaborator Author

magik6k commented Apr 18, 2018

push should also print ipns::QmKey like it currently does with the ipld helper

@dirkmc
Copy link
Contributor

dirkmc commented Apr 18, 2018

Currently it prints the IPFS hash of the patched object with an ipns:: prefix, eg
Pushed to IPFS as ipns::Qmeue...
Do you think it would make sense to instead update the IPNS key to point to this IPFS key and print
Pushed to IPFS as /ipfs/Qmeue...
Updated IPNS key /ipns/QmIPNSKey to point to /ipfs/Qmeue...

@magik6k
Copy link
Collaborator Author

magik6k commented Apr 18, 2018

We could print both, but it might be confusing for some users. I'd keep the ipns:: prefix as it allows for easier copy-paste, and only print ipns key to not confuse users unfamiliar with ipfs.

@dirkmc
Copy link
Contributor

dirkmc commented Apr 18, 2018

Ok so I'm imagining that the user would do one of the following:

  • git push --set-upstream ipns::/ipns/QmIPNSkey branchname
  • git push --set-upstream ipns:: branchname
    In the second case the ipns helper would mint an ipns key for the user

At the end it would print
Pushed to IPFS as ipns::/ipns/QmIPNSkey...

Does that sound right?

@magik6k
Copy link
Collaborator Author

magik6k commented Apr 19, 2018

Yep, that's about right. We might also want to store mapping between branches and keys in the tracker

@dirkmc
Copy link
Contributor

dirkmc commented Apr 23, 2018

It seems like there is a bug in go-ipfs-api ipns name publish so I will wait till you have completed the work on core API

@Arlodotexe
Copy link

Arlodotexe commented Jun 28, 2023

Think we can move forward on this now?

@mainiak
Copy link

mainiak commented Jun 29, 2023

I thought this doesn't really work?

Unless I did something wrong when I was trying to use it - https://gist.github.com/mainiak/03f202480405affca3fd80dd8f6a7008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants