Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete around_the_library.html and get_random_recent_changes if unused #9896

Open
2 tasks
scottbarnes opened this issue Sep 20, 2024 · 2 comments
Open
2 tasks
Assignees
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]

Comments

@scottbarnes
Copy link
Collaborator

scottbarnes commented Sep 20, 2024

Problem

We should delete openlibrary/templates/site/around_the_library.html and get_random_recent_changes from openlibrary/plugins/upstream/utils.py if unused.

Breakdown

Requirements Checklist

  • Verify the two things above are not called by anything besides perhaps one another by looking at the code (perhaps with the help of git grep).
  • IF they are unused, delete the file and function.

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@scottbarnes scottbarnes added Type: Bug Something isn't working. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Sep 20, 2024
@JorgeSanchez-Encora
Copy link

Hello!, can this issue be assigned to me?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Sep 20, 2024
@scottbarnes scottbarnes added Lead: @scottbarnes Issues overseen by Scott (Community Imports) Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Needs: Response Issues which require feedback from lead Type: Bug Something isn't working. [managed] labels Sep 20, 2024
@scottbarnes
Copy link
Collaborator Author

scottbarnes commented Sep 20, 2024

@JorgeSanchez-Encora, I've assigned this to you. Because of the nature of this task, it's a bit hard to demonstrate it had no adverse effects across the entire site, but if you determine these things can be deleted, please explain the steps you took and your rationale in making that determination. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Development

No branches or pull requests

2 participants