Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Shouldn't Render on OEmbed Posts #16

Open
mrjarbenne opened this issue Aug 30, 2016 · 2 comments
Open

UI Shouldn't Render on OEmbed Posts #16

mrjarbenne opened this issue Aug 30, 2016 · 2 comments

Comments

@mrjarbenne
Copy link

Now that WP supports oembed for blog posts, the Hypothesis toolbar is being rendered multiple times, both on the sidebar, and in each oembed post.

If possible, the toolbar shouldn't be present in the oembed template because one wouldn't read annotations in that smaller viewport.

2016-08-29_21-47-08

@robertknight
Copy link
Member

Hello,

We've made a start on some initial work to support documents which have other documents embedded via iframes which may be of help here. Do you have an example of a link to a post which uses OEmbed and Hypothesis?

@mrjarbenne
Copy link
Author

Hi @robertknight. Here's the post from the screenshot, from a Multisite instance of WP, running the hypothes.is plugin (version 0.5.0). Sorry for the delayed response. Hope this helps:

https://mrjarbenne.ca/2016/03/25/innovation-vs-consistency/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants