Add custom layout #832

SilvanVerhoeven · 2021-05-27T16:09:32Z

Closes #626

linusha

I might investigate further tomorrow but I noticed the following:

Opening the editor for the first time in a world now leads to an Error because position (I do not remember on what, sorry) cannot be set to undefined.

frcroth · 2021-06-01T07:57:01Z

I might investigate further tomorrow but I noticed the following:

Opening the editor for the first time in a world now leads to an Error because position (I do not remember on what, sorry) cannot be set to undefined.

TypeError: Cannot set property 'position' of undefined

    at InteractivesEditor_relayout_ (http://localhost:9011/qinoq/editor.js:272:45)
    at callOrSetTarget (http://localhost:9011/lively.bindings/index.js:556:82)
    at AttributeConnection_update_ (http://localhost:9011/lively.bindings/index.js:563:92)
    at eval (http://localhost:9011/lively.bindings/index.js:624:23)
    at Array.forEach (<anonymous>)
    at InteractivesEditor.eval [as extent] (http://localhost:9011/lively.bindings/index.js:622:48)
    at InteractivesEditor.Morph_setBounds_ (http://localhost:9011/lively.morphic/morph.js:904:27)
    at Window_relayoutWindowControls_ (http://localhost:9011/lively.components/window.js:252:36)
    at Window.set [as title] (http://localhost:9011/lively.components/window.js:906:26)

Which makes sense, since extent may be set before the panels are initialized

frcroth

Code is ok, but I think we may need to discuss what we expect a full sized editor to look like

SilvanVerhoeven · 2021-06-01T08:17:19Z

I might investigate further tomorrow but I noticed the following:

Opening the editor for the first time in a world now leads to an Error because position (I do not remember on what, sorry) cannot be set to undefined.

Fixed that and another bug

SilvanVerhoeven · 2021-06-01T08:17:35Z

Code is ok, but I think we may need to discuss what we expect a full sized editor to look like

Before or after merge?

frcroth · 2021-06-01T08:31:31Z

Code is ok, but I think we may need to discuss what we expect a full sized editor to look like

Before or after merge?

Before

T4rikA · 2021-06-01T12:41:03Z

Also scrolling is not possible in the complete preview, just in the left half

frcroth · 2021-06-03T07:30:32Z

Can not open the editor on this branch currently

linusha

I feel that it should not be necessary, but maybe @Paula-Kli or @SilvanVerhoeven can confirm - are deserialization checks necessary for extent on the InteractiveGraph the ResizablePanel or for _latestSubWindowRatio?

I'd also be in favor of merging this after the necessary PR in lively.next was merged, would that be ok? If you'd prefer help bringing the changes that are necessary for Robins approval on the way we can tackle it on Monday @SilvanVerhoeven!

linusha · 2021-06-05T21:59:03Z

inspector/index.js

+    if (this.interactive &&
+        this.interactive.sequences.includes(Sequence.getSequenceOfMorph(morph))) {


Is this an intended change or was it introduced by windows formatting complications?

Doesn't Sequence.getSequenceOfMorph already check whether there is a Sequence in the interactive?

@linusha This is intended
@Paula-Kli No, it only traverses the morph owner change until the first Sequence

SilvanVerhoeven · 2021-06-10T15:33:14Z

Open Problems with this PR

* [x]   Tree is too high

* [ ]  Zooming the Interactive and Resizing the top panel do not play good together

* [ ]  Saving should be investigated before merging, has not been checked until now

We won't change something about the zooming, as there are dependencies with other branches

SilvanVerhoeven · 2021-06-14T08:00:03Z

frcroth · 2021-06-14T08:04:17Z

Standard sequence graph extent seems off (This only happens with the first editor in a new world)

linusha · 2021-06-14T08:03:03Z

editor.js

@@ -227,6 +272,7 @@ export class InteractivesEditor extends QinoqMorph {

    connect(this.interactive, 'remove', this, 'reset');
    connect(this.interactive, '_length', this.ui.menuBar.ui.scrollPositionInput, 'max').update(this.interactive.length);
+    // TODO: let this work with zoom


I'd appreciate if this stays for now please.

linusha · 2021-06-14T08:03:38Z

inspector/index.js

+      extent: {
+        set (extent) {
+          this.setProperty('extent', extent);
+          // if (this._deserializing) return;


Is this save to remove? If so, can it go for good?

If this is the same as the check below I would appreciate if we use this instead

It's not, can/should be removed

What is the difference?

frcroth · 2021-06-14T08:26:53Z

editor.js

+
+    this.ui.interactiveGraph.extent = pt(
+      this.ui.interactiveGraph.width,
+      topWindowHeight - this.ui.interactiveGraph.submorphs[0].height -


What does the submorphs[0] do? Aren't there two submorphs in the interactiveGraph

T4rikA

When the deserializing discussion is resolved

Co-authored-by: T4rikA <[email protected]> Co-authored-by: linusha <[email protected]>

Co-authored-by: frcroth <[email protected]> Co-authored-by: Paula-Kli <[email protected]>

linusha · 2021-06-14T19:12:22Z

I re-requested reviews from everybody again since there were so many changes in here that I do not think that these actually reflect the review state. Feel free to just re-approve if you think otherwise. Personally, I'll not add a new review before we are done here.

frcroth · 2021-06-15T08:01:34Z

tree.js

+            this.tree.extent = adjustedExtent;
+          }


Why do we set the extent of the tree to the same as the overall extent? Shouldn't the tree be smaller as the search field needs to be subbtracted

linusha · 2021-06-15T12:09:17Z

Attention

commit f1e3bbb will be merged separately, needs to be dropped her
The interactive and its aspect ratio do currently not play well with the relayouting, i.e. change whenever the window of the editor is e.g., clicked. This would need to be tackled before merging this.

Add custom layout

b857014

github-actions bot assigned SilvanVerhoeven May 27, 2021

github-actions bot requested review from frcroth, linusha, Paula-Kli and T4rikA May 27, 2021 16:09

linusha reviewed May 29, 2021

View reviewed changes

Fix bug on startup

036a567

frcroth reviewed Jun 1, 2021

View reviewed changes

Fix layout bug of inspector tabs

eea9235

SilvanVerhoeven requested review from frcroth and linusha June 1, 2021 08:17

T4rikA mentioned this pull request Jun 2, 2021

Last layer in sequence view not visible #896

Closed

SilvanVerhoeven added 2 commits June 2, 2021 17:13

WIP: Integrate resizeable panel into editor

59ba5c3

Refresh layout on resize end

8e0c990

SilvanVerhoeven added 4 commits June 3, 2021 10:32

Enable proportional panel resizing on window resize

09c90e6

Remove comment

4908db8

Make interactive graph responsive to resize

536e12f

Make inspector responsive to resize

2ef7eba

frcroth marked this pull request as draft June 3, 2021 10:05

SilvanVerhoeven marked this pull request as ready for review June 3, 2021 10:22

frcroth linked an issue Jun 3, 2021 that may be closed by this pull request

Better Scaling for the Editor #571

Open

frcroth approved these changes Jun 5, 2021

View reviewed changes

linusha approved these changes Jun 5, 2021

View reviewed changes

SilvanVerhoeven mentioned this pull request Jun 10, 2021

Limit Preview extent #975

Closed

SilvanVerhoeven added 2 commits June 14, 2021 00:04

Make editor saveable

03f8886

Fix inspector layouting bug

02b249e

linusha requested review from linusha, frcroth, Paula-Kli and T4rikA June 14, 2021 07:58

linusha reviewed Jun 14, 2021

View reviewed changes

frcroth reviewed Jun 14, 2021

View reviewed changes

Paula-Kli approved these changes Jun 14, 2021

View reviewed changes

T4rikA approved these changes Jun 14, 2021

View reviewed changes

SilvanVerhoeven force-pushed the enhancement/layout-sizes branch from 2895573 to 9904797 Compare June 14, 2021 10:42

T4rikA and others added 2 commits June 14, 2021 13:50

Fix tree height

d0215d2

Co-authored-by: T4rikA <[email protected]> Co-authored-by: linusha <[email protected]>

Fix rebasing issue and remove debugger

883d16c

Co-authored-by: frcroth <[email protected]> Co-authored-by: Paula-Kli <[email protected]>

T4rikA force-pushed the enhancement/layout-sizes branch from 9904797 to 93ed418 Compare June 14, 2021 12:17

T4rikA and others added 2 commits June 14, 2021 15:04

Fix saving issues with resizeable panels

3983838

Co-authored-by: frcroth <[email protected]> Co-authored-by: Paula-Kli <[email protected]>

Decouple sequence extents from preview

a435a70

linusha requested review from Paula-Kli, T4rikA, frcroth and linusha June 14, 2021 19:10

frcroth reviewed Jun 15, 2021

View reviewed changes

frcroth force-pushed the dev branch from 0e56e3b to f7f6e7c Compare August 11, 2021 11:53

linusha force-pushed the enhancement/layout-sizes branch from f1e3bbb to a435a70 Compare August 17, 2021 19:52

linusha force-pushed the dev branch from e393f24 to 30d18f6 Compare September 14, 2021 21:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add custom layout #832

Add custom layout #832

SilvanVerhoeven commented May 27, 2021 •

edited by linusha

Loading

linusha left a comment

frcroth commented Jun 1, 2021

frcroth left a comment

SilvanVerhoeven commented Jun 1, 2021

SilvanVerhoeven commented Jun 1, 2021

frcroth commented Jun 1, 2021

T4rikA commented Jun 1, 2021

frcroth commented Jun 3, 2021

linusha left a comment

linusha Jun 5, 2021

Paula-Kli Jun 6, 2021

SilvanVerhoeven Jun 10, 2021

SilvanVerhoeven commented Jun 10, 2021

Open Problems with this PR

SilvanVerhoeven commented Jun 14, 2021 •

edited

Loading

frcroth commented Jun 14, 2021 •

edited

Loading

linusha Jun 14, 2021

linusha Jun 14, 2021

T4rikA Jun 14, 2021

SilvanVerhoeven Jun 14, 2021

T4rikA Jun 14, 2021

frcroth Jun 14, 2021

T4rikA left a comment

linusha commented Jun 14, 2021

frcroth Jun 15, 2021

linusha commented Jun 15, 2021

		if (this.interactive &&
		this.interactive.sequences.includes(Sequence.getSequenceOfMorph(morph))) {

Add custom layout #832

Are you sure you want to change the base?

Add custom layout #832

Conversation

SilvanVerhoeven commented May 27, 2021 • edited by linusha Loading

linusha left a comment

Choose a reason for hiding this comment

frcroth commented Jun 1, 2021

frcroth left a comment

Choose a reason for hiding this comment

SilvanVerhoeven commented Jun 1, 2021

SilvanVerhoeven commented Jun 1, 2021

frcroth commented Jun 1, 2021

T4rikA commented Jun 1, 2021

frcroth commented Jun 3, 2021

linusha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SilvanVerhoeven commented Jun 10, 2021

Open Problems with this PR

SilvanVerhoeven commented Jun 14, 2021 • edited Loading

frcroth commented Jun 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

T4rikA left a comment

Choose a reason for hiding this comment

linusha commented Jun 14, 2021

Choose a reason for hiding this comment

linusha commented Jun 15, 2021

Attention

SilvanVerhoeven commented May 27, 2021 •

edited by linusha

Loading

SilvanVerhoeven commented Jun 14, 2021 •

edited

Loading

frcroth commented Jun 14, 2021 •

edited

Loading