Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Participate#Submission #57

Open
2 of 4 tasks
carlinmack opened this issue Dec 3, 2019 · 34 comments
Open
2 of 4 tasks

Issues with Participate#Submission #57

carlinmack opened this issue Dec 3, 2019 · 34 comments

Comments

@carlinmack
Copy link
Contributor

carlinmack commented Dec 3, 2019

https://openmoji.org/styleguide/#submission

@b-g
Copy link
Member

b-g commented Dec 4, 2019

Hi @carlinmack, Yes!

  1. yes! Could you add the export infos for inkscape (and affinity)?
  2. yes! But I would only link to CONTRIBUTING.md e.g. "How to contribute for developers", as the reality is that a lot of designers struggle with Git. We deliberately didn't put all the Github stuff under /styleguide ... as the threshold should be as low as possible to contribute. And the Pros know the Github anyway.
  3. ?? The entire page is the styleguide ...

@carlinmack
Copy link
Contributor Author

carlinmack commented Dec 4, 2019

  1. I know, that's why I don't think it shouldn't be called "Participate" haha, I think Participate could be a subheading on this page and have sections for designers (what design work we need) and developers (link to CONTRIBUTING.md)

@b-g
Copy link
Member

b-g commented Dec 4, 2019

I know, that's why I don't think it shouldn't be called "Participate" haha, I think Participate could be a subheading on this page and have sections for designers (what design work we need) and developers (link to CONTRIBUTING.md)

Still not sure whether I understand. I like that the title in the navigation is participate (and not styleguide) as this underpins IMO better that everyone can actually participate, whereas as styleguide is normally something static. Hence I would leave the page title as it is.

However it is a good call to make the subtitles more explicit. Maybe instead of "Participate" a "Contribute" section, or dedicated sections for Illustrator, Inkscape and Affinity?

@carlinmack
Copy link
Contributor Author

I also like having Participate in the header but the first thing you should see on the page should be how to participate. Right now users are shown the grid we use which isn't very informative.

@b-g
Copy link
Member

b-g commented Dec 4, 2019

Yes, your are right. Maybe we could start with a general paragraph and then all the styleguide sections and conclude how to contibute / submit etc.?

@carlinmack
Copy link
Contributor Author

Yep that sounds good!

@dnlutz
Copy link
Contributor

dnlutz commented Dec 5, 2019

I'm aware that there is some work lurking for me in this area ; )
In the near future, I would structure the "Participate" page like this:

Intro / Call for participation

  • OpenMoji needs You
  • Please contribute the missing Unicode 13 Emoji

Design: Basics

  • Sizes, Colors, Line Widths, Shadows …

Design: Things to Do

  • Examples for not yet perfect Emoji and how to improve them
  • this will also be a new styleguide chapter

Technical Basics

  • Curve quality, Anchor points, Layer Structure, Do's and Dont's …

Contribution

  • Export and production from various sources
  • Maybe we will even accept neatly designed (illustrator) source files?

@b-g
Copy link
Member

b-g commented Dec 5, 2019

@dnlutz ok :) This will be quite a restructuring ... this seems rather realistic towards spring (Feb 2020).

Maybe we could in the meantime improve it slightly:

  • Starting with a nice short general text on "how to and why to participate". As @carlinmack said ... currently not optimal to start with "Grid"
  • Add submission instructions for Inkscape and Affinitiy
  • Add prominent link to CONTRIBUTING.md

@carlinmack
Copy link
Contributor Author

I can do the instructions for Inkscape/Affinity sometime after the 13th as finals week is kicking in, most of my contributions will be very minimal until then

@b-g
Copy link
Member

b-g commented Dec 5, 2019

Great + NP + Thanks! Same for me :) Good luck for your final weeks!

@carlinmack
Copy link
Contributor Author

Inkscape instructions were done in 30e8879

@b-g
Copy link
Member

b-g commented Jan 27, 2020

@carlinmack Maybe another quick win might be a first "greeting" paragraph ... instead of the not so warm welcome with the grid section?

@carlinmack
Copy link
Contributor Author

carlinmack commented Jan 27, 2020

Here's what I have so far, thoughts? @dnlutz @b-g

image
image

@b-g
Copy link
Member

b-g commented Jan 28, 2020

@carlinmack Nice!! Comments:

  • Would move emoji 13 up as top prio and link a Github issue with a list
  • Big headline has to really align left ... otherwise all HfG people go crazy in terms of "good" typography :)
  • Big headline text ... maybe better? "Designer? Developer? Opensource Enthusiast? Everyone Is Welcome to Participate!"
  • All titles should be Title Case
  • "Improve design of emojis" > "Improve Quality of OpenMoji"
  • "Help design new emoji" > "Help Design New OpenMojis"

What do you think?
cc @dnlutz @bohnacker

@bohnacker
Copy link
Member

@carlinmack: Cool. Great work on the website!
@b-g: Agree with all of it. I don't really like Title Case but maybe that's a personal thing :-)

@carlinmack
Copy link
Contributor Author

  1. 👍
  2. 👍 I am not trained in typography, I'll do as you say haha. btw it's the styling from the front page "OpenMoji is an open source project of 53 students..."
  3. I think this is a good compromise "Designer? Developer? Love Open Source? Everyone Can Participate!"
  4. Agree with bohnacker, not sure
  5. and 6. I prefer "Emoji"/"Emojis" in both cases. For a catchy tagline I think we should stick with ideas that people are more likely to already care about. I think designers are fundamentally interested in improving emoji in general whereas as they probably don't care about improving OpenMoji (yet).

Please criticise my "emoji 13.0", haven't been trained to do good kerning haha. I think the stroke is too eye catching and dominates the heading.

@b-g
Copy link
Member

b-g commented Jan 28, 2020

  1. 👍 "Designer? Developer? Love Open Source? Everyone Can Participate!"
  2. I'm fine either way ... and I'm not attached to Title Case. But it has to be consistent over the entire Styleguide, which currently is Title Case. Either we normalize everything or we stick with Title Case. All Good For Me.
  3. / 6. OK 👍 for "Emoji" and "Emojis" ... your are the native speaker :)
  4. Image "emoji 13.0" is fine for me too ... Daniel can tweak it if he wants :)

@carlinmack
Copy link
Contributor Author

Opened PR #72

@dnlutz
Copy link
Contributor

dnlutz commented Jan 29, 2020

The call for participation for emoji 13 is important.But we should definitely wait until we have improved guidelines, a step-by-step design and technical tutorial AND an improved illustrator file to start with. I know this is a lot of work but we have to do it before we publish our call. I'm sorry that at the moment I am still too busy with other projects but an end is foreseeable.

@carlinmack / @b-g We have to work together on this topic: i see emoji 13 as an opportunity to significantly improve the quality of our emoji. At the moment OpenMoji contains many very good emoji but also some mediocre and even bad ones that are not consistent with the rest.

In addition to the guidelines we also have to think about how to find comrades-in-arms outside Github. Many designers are not on Github, so that's a serious issue.

@carlinmack
Copy link
Contributor Author

carlinmack commented Jan 29, 2020

So to do:

  • improved guidelines
  • a step-by-step design tutorial
    • Sizes, Colors, Line Widths, Shadows …
  • a step-by-step technical tutorial
    • Curve quality, Anchor points, Layer Structure, Do's and Dont's …
    • Export and production from various sources
  • an improved illustrator file that already contains some basic shapes / components / examples to start with
  • how to find comrades-in-arms outside Github
    • Hopefully there is some /r/programmingrequests for graphic design we can ask

What do you mean with the fourth item?

Anyone can edit my comment and change this list if they want

@dnlutz
Copy link
Contributor

dnlutz commented Jan 30, 2020

Thank you for the list! The fourth item is more a question than a to-do: How could we motivate experienced designers / illustrators to participate in OpenMoji? These people often don't use GitHub (or they struggle with it like myself ; )

Irrespective of this: it will take some time to process the list. So it would be great if you could update the intro of the participate page. The layout and the content is good, it's much more motivating than just the grid.

The only element I would reconsider is the emoji with the big eyes (> improve design of emoji). The eyes are not typical for the guidelines. If you want you can use this polar bear or maybe you find another good example. I think it would be good to not only show smileys.

polar_bear

@carlinmack
Copy link
Contributor Author

carlinmack commented Jan 30, 2020

Sorry I meant what do you mean with this "an improved illustrator file to start with"

I'll change to the polar bear, that was just the first example that I came up with.

Is the polar bear for Emoji 13 (hfg-gmuend/openmoji#124)? If so tick it off the list when you add the design :)

@dnlutz
Copy link
Contributor

dnlutz commented Jan 30, 2020

ah ok … A file that already contains some basic shapes / components / examples might be helpful for newbies. It would be easier to use these components to build something new.

@carlinmack
Copy link
Contributor Author

Oh I see that would be good, I do a lot of finding similar emojis and using their assets so this would be very helpful!

additionally the openmoji font is currently only distributed as a illustrator file, I'll update the website with a plain SVG version

@carlinmack
Copy link
Contributor Author

I would add that we need to:

  • Add information for what work we need from developers.

There's stuff with OpenMoji font for sure, but we should have a to do list

@b-g
Copy link
Member

b-g commented Feb 6, 2020

Hi @carlinmack!

On mobile the styleguide lacks a separation between our prompt ("please help us") and where the styleguide actually starts. I think an additional headline "Styleguide" or any other separator element would be helpful, or?

You can check it with your phone on staging:
https://hfg-gmuend.github.io/openmoji-website/styleguide/

@carlinmack
Copy link
Contributor Author

Yeah I think a headline that says Styleguide would be good, however we use <h1>s for the Grid, Contour etc headings already so it would look like this

Designer? Developer?

Love Open Source?

Everyone Can Participate!

Help Design New Emoji

The next set of emojis are due to be released...

Improve Consistency with Other Platforms

To be useful for communication, emoji need to...

Improve Quality of Emojis

Design is subjective but we want our emoji to...

Styleguide

Grid

The Grid serves as orientation for the size of...

Basic Forms

@b-g
Copy link
Member

b-g commented Feb 6, 2020

Well we could introduce a gentle line (like Github does often) eg.:

Designer? Developer?
Love Open Source?
Everyone Can Participate!

content
...

Styleguide

content
...

@carlinmack
Copy link
Contributor Author

yeah that would work nicely 👍

@carlinmack
Copy link
Contributor Author

should I do this?

@b-g
Copy link
Member

b-g commented Feb 10, 2020

@carlinmack I won't say no! :) Would be wonderful!

@carlinmack
Copy link
Contributor Author

done 4c90779

@b-g
Copy link
Member

b-g commented Feb 11, 2020

@carlinmack Great + Many thanks!!

@carlinmack
Copy link
Contributor Author

carlinmack commented Feb 11, 2020

Created #76 so that we can keep this focused on the submission part of the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants