Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent SSID Lengths Due to Variable id Length in ComputeSSID #296

Open
B08902060 opened this issue Jul 3, 2024 · 1 comment
Open

Comments

@B08902060
Copy link

B08902060 commented Jul 3, 2024

The current implementation of the ComputeSSID function can lead to inconsistencies in the length of the generated SSID. This issue arises because the id parameter can have a variable length, resulting in SSIDs of varying lengths. Consequently, this can cause the SSID and ZKSsid lengths to be inconsistent, which has been observed to cause failures in verifying the Pedersen parameter proof during the resharing process.

Additionally, during the Reshare phase, the id used to compute ssid is derived from dkgResult.Bks[selfId].String(), generated during the DKG phase.

Is there any special significance to the current implementation, or can I use padding to address this issue?

@B08902060
Copy link
Author

B08902060 commented Sep 20, 2024

I am working on fixing this issue because I encountered the same error mentioned in a previous issue: #233. To address this, I attempted to resolve the problem by fixing the input string length of ZKSSID, specifically for bks.x.

return fmt.Sprintf("(x, rank) = (%s, %d)", p.x, p.rank)

You can review the changes in the comparison below:

    return fmt.Sprintf("(x, rank) = (%078s, %d)", p.x, p.rank)

Fix bks.x length (with testcase)
Is this approach feasible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant