Inner types of ignored external types are generated anyway

[gshep]

Problem

Not sufficient however would be nice to fix it. Generated Rust code contains redundant entities however they are inner types of ignored external ones.

Steps

1. the same as in Generated Rust code from idl with set external type requires PartialEq #556
2. generated idl_external_type_client.rs will contain the Inner struct. The file excerpt is attached.

Possible Solution

The basic idea is to make two passes. During the first pass populate inner external_types map. On the second pass the current logic is kept.

Notes

No response

Relevant Log Output

Click to expand/collapse

#[derive(PartialEq, Debug, Encode, Decode, TypeInfo)]
#[codec(crate = sails_rs::scale_codec)]
#[scale_info(crate = sails_rs::scale_info)]
pub struct Message(pub Data);
#[derive(PartialEq, Debug, Encode, Decode, TypeInfo)]
#[codec(crate = sails_rs::scale_codec)]
#[scale_info(crate = sails_rs::scale_info)]
pub struct Inner(pub u32);

pub mod traits {

[DennisInSky]

We can't skip generating types as IDL is used for generating clients not just for Rust, but for other languages as well where external Rust crates are unavailable

[gshep]

reopened since we discussed it in dm

[DennisInSky]

A possible solution would be recursively marking a type as external provided it is referenced from another type marked as external.

[gshep]

It would be also nice to prefix such external types with pub

[vobradovich]

See #556 (comment)

In some cases it may be necessary to use external container types for the generated types, like struct MyContainer<T>(value: T); instead of the generated MyContainerForT. The type T itself must remain generated.

My point of view is that the developer should explicitly specify which types to use instead of the generated ones.

[DennisInSky]

@gshep what do you think if we close this issue due to the generics. We can't seem to write a generic algoritm for marking inner types as external ones - IDL doesn't communicate any info about generics.