Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-builder uses hacks to build WASMs #4235

Open
StackOverflowExcept1on opened this issue Sep 14, 2024 · 0 comments
Open

wasm-builder uses hacks to build WASMs #4235

StackOverflowExcept1on opened this issue Sep 14, 2024 · 0 comments
Assignees
Labels
C0-bug Something isn't working P1-asap High priority

Comments

@StackOverflowExcept1on
Copy link
Member

StackOverflowExcept1on commented Sep 14, 2024

Problem

Starting with Rust 1.82 WASMs contain multi-value and reference-types features: https://blog.rust-lang.org/2024/09/24/webassembly-targets-change-in-default-target-features.html.

We currently use hack #4247 to solve this issue. This hack results in end user having to install rust-src component, -Zbuild-std increases build time, removing -Clinker-plugin-lto increases binary sizes, and RUSTC_BOOTSTRAP=1 reduces stability since the user may be using nightly features in WASMs.

Steps

No response

Possible Solution

Notes

No response

Relevant Log Output

No response

@StackOverflowExcept1on StackOverflowExcept1on added P1-asap High priority C0-bug Something isn't working labels Sep 14, 2024
@StackOverflowExcept1on StackOverflowExcept1on changed the title wasm-builder: can't build contracts/runtime with beta version of rust wasm-builder uses hacks to build WASMs Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C0-bug Something isn't working P1-asap High priority
Projects
None yet
Development

No branches or pull requests

1 participant