Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fyne run command to cli #12

Open
2 tasks done
rad756 opened this issue Mar 10, 2024 · 7 comments
Open
2 tasks done

Add fyne run command to cli #12

rad756 opened this issue Mar 10, 2024 · 7 comments
Labels
fyne command Issue related to the cmd/fyne command

Comments

@rad756
Copy link

rad756 commented Mar 10, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

The command go run . will not see FyneApp.toml and error out that appID is missing.

Is it possible to construct a solution with the existing API?

It should be able to modify fyne build, to create a new feature, fyne run that will work similar to go run . but it will recognize FyneApp.toml, without building a copy of the app in the project directory

Describe the solution you'd like to see.

Create a fyne run cli command which would act like go run . but will be able to see FyneApp.toml and not error out about missing appID if in main.go you have app.New instead of app.NewWithID()

@andydotxyz
Copy link
Member

This relates to new functionality, and for the CLI tool we are moving development to fyne-io/tools - so I will move this issue over.

@andydotxyz andydotxyz transferred this issue from fyne-io/fyne Mar 11, 2024
@andydotxyz
Copy link
Member

I wonder if this relates to fyne-io/fyne#4688

@rad756
Copy link
Author

rad756 commented Mar 11, 2024

Issue fyne-io/fyne#4688 relates to go build . and this one relates to go run .
Although it could be a "merged" issue since it feels like splitting hairs at this stage.
Since I assume that if the functionality gets added to go build, it will probably also get added to go run.

@dweymouth
Copy link

I wonder if this relates to fyne-io/fyne#4688

Related, but it doesn't seem like a duplicate. The request in 4688 is a way to embed the FyneApp.toml metadata without also doing -H=windowsgui (presumably so that debug logs can be seen during development, but still have the FyneApp metadata in the build)

@andydotxyz
Copy link
Member

andydotxyz commented Mar 12, 2024

If fyne-io/fyne#4715 lands I think this is request no longer adds anything - from the OP:

would act like go run . but will be able to see FyneApp.toml and not error out about missing appID if in main.go you have app.New instead of app.NewWithID()

With the proposed change "go run" behaves like that without needing any new fyne command.

@andydotxyz
Copy link
Member

From v2.5.0 the metadata will be included with go tools. Do we still need a "fyne run" command?

@rad756
Copy link
Author

rad756 commented Apr 5, 2024

If from v2.5.0 while using go run . it will notice FyneApp.toml. It might make fyne run command redundant, unless I do not know how else go run . would differ from running the built binary from fyne build

@Jacalz Jacalz added the fyne command Issue related to the cmd/fyne command label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fyne command Issue related to the cmd/fyne command
Projects
None yet
Development

No branches or pull requests

4 participants