Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Settings Reference mismatch with typescript type definition #3081

Open
kutoman opened this issue Aug 4, 2024 · 2 comments
Open

Modal Settings Reference mismatch with typescript type definition #3081

kutoman opened this issue Aug 4, 2024 · 2 comments
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Milestone

Comments

@kutoman
Copy link
Contributor

kutoman commented Aug 4, 2024

Bug Report

the type definition here (transition: string | Partial<Pick<TransitionSettings, keyof TransitionSettings>>) does not match with
the example for the transition settings from https://fomantic-ui.com/modules/modal.html#/settings:

{
    showMethod   : 'fade',
    showDuration : 200,
    hideMethod   : 'zoom,
    hideDuration : 500,
}

Expected result

The keys from the documentation's example object are correct. The type definition should reflect that. Thus, something like:
transition: string | ModalTransitionSettings

@kutoman kutoman added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Aug 4, 2024
@lubber-de
Copy link
Member

Should be fixed by #3082
@kutoman Can you test my changes?

@lubber-de lubber-de added state/has-pr An issue which has a related PR open and removed state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels Aug 4, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Aug 4, 2024
@kutoman
Copy link
Contributor Author

kutoman commented Aug 5, 2024

@lubber-de yes that's it 👍

@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants