Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEPTEMBER MASTER ISSUE #501

Open
23 of 44 tasks
NealHumphrey opened this issue Aug 29, 2017 · 3 comments
Open
23 of 44 tasks

SEPTEMBER MASTER ISSUE #501

NealHumphrey opened this issue Aug 29, 2017 · 3 comments

Comments

@NealHumphrey
Copy link
Collaborator

NealHumphrey commented Aug 29, 2017

This is still a work in progress - I need to create some issues for bullet points here, as well as go through all open issues to add any additional ones that need to be addressed before launch.

Map View

Project View

Add data sources to filter sidebar:

Front end - If time

Data Processing

Server

General Website Stuff

  • Add "?" links to all data fields linking to the appropriate data documentation page. (Add links to data documentation in each 'filter' or 'layer' selection section #360)ZoneFacts table will provide this for any calculated fields.
  • Add a landing page (Create a Landing Page #504) and/or landing modal
  • Add a joyride tour of key features: filtering, chloropleths, selecting buildings, null data.
  • Add 3 saved analyses (using the url encoding) and use these to introduce the types of things the tool can do to new users; put these on the landing page.
  • Add a the navbar from the whole site to the top of the tool
  • Add Google Analytics
  • Auto-population of data fields in Jekyll data documentation (still needs styling)
@NealHumphrey NealHumphrey changed the title September Master Issue SEPTEMBER MASTER ISSUE Aug 30, 2017
@ostermanj
Copy link
Collaborator

@NealHumphrey I can jump on the finalizing URL encoding stuff. What's the issue with color-coding on decode?

@NealHumphrey
Copy link
Collaborator Author

@ostermanj When I load a saved URL (i.e. refresh the page with a few filters activated), the filters apply correctly to the right hand side panel summary stats - therefore it seems like the filterData is working properly - but all of the dots on the map are orange. If I then select an additional filiter on the page, dot-coloring resumes as normal. It seems to happen with all filters in my browser (Chrome on Windows) - I can come up with specific scenarios if you are not able to recreate. I'm online working today (starting with reviewing your open pull requests) so let me know if you can't replicate the problem.

@ostermanj
Copy link
Collaborator

Got the color coding work locally. Will push after finishing the other decode tasks.

__
The filter decoding was happening too quickly after initialLayers were added, before they were fully rendered. Solutions uses mapBox's render event, checks against state of initialLayersAdded and !isFilterInitialized to setState initialProjectsRendered. router.initFilters subscribes to that stateChange and turns isFilterInitialized to true so that this stateChange fires only once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants