-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunk nginx cache #415
Comments
There's actually another wringle here that's going to be tricky. that translation is not something we have code for, and i wonder if it is complexity we want the shim to have to handle. |
Hm.. it this gets too hairy (and it already pretty hairy), may be worth considering if it is less/equal amount of glue code if cache is built around blocks, and not HTTP responses. If the nginx module always stored individual blocks, and assembled CARs and CAR-slices on the fly based on some index, CAR and fallback block requests would share the same block cache, and we would remove DoS surface that comes from CARs that have duplicate blocks, or storing same blocks multiple times due to different CAR flavours. |
I think i agree that it's worth considering. I'm pretty reluctant to support that scope for a first iteration of rhea to launch because it will take a very substantial effort and complexity to get a cache that performs at the level of nginx. |
The current translation looks like
We should have the
nginx caching
layer include a directive likeThis will update the sequence to look like:
There are 3 things needed for this to land:
slice
directive in nginxbytes
argument in l1 shimThe text was updated successfully, but these errors were encountered: