Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load config from a config.json file #208

Open
guanzo opened this issue Feb 6, 2023 · 2 comments
Open

Load config from a config.json file #208

guanzo opened this issue Feb 6, 2023 · 2 comments
Assignees

Comments

@guanzo
Copy link
Collaborator

guanzo commented Feb 6, 2023

Config is currently set with environment variables. Env vars are set in the docker compose file. The docker compose file is basically locked since we don't want to force node operators to update it.

Solution: Check for a /usr/src/app/shared/config.json file, which is mapped to $SATURN_HOME/shared/config.json on the host filesystem.

- ${SATURN_HOME:-$HOME}/shared:/usr/src/app/shared

This will allow us to configure behavior without changing the docker compose file. Config files are also more flexible than env vars.

Let's implement this when the current config system becomes a pain point. There are more pressing issues atm (Rhea/Lassie).

@joaosa
Copy link
Contributor

joaosa commented Apr 5, 2023

Do we still need this? Or is the .env load on docker compose good enough for now? I think it would be good to scope deployment-specific configs from application-specific ones.

@DiegoRBaquero
Copy link
Collaborator

As soon as there's a new config value that is worthy of a file, let's do it. But for now env works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants