Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling File Icons does not restore default icons #682

Open
winstliu opened this issue Dec 9, 2017 · 2 comments
Open

Disabling File Icons does not restore default icons #682

winstliu opened this issue Dec 9, 2017 · 2 comments
Assignees
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.
Milestone

Comments

@winstliu
Copy link

winstliu commented Dec 9, 2017

Not sure if this belongs here or if it's due to the new icon services but I thought this would be a good place to start.

Disabling the file-icons package completely removes all icons rather than letting packages fallback to their default icons. For the Tree View, it occasionally appears to fallback correctly the first time but subsequent disables removes all icons. Icons never come back for the Archive View or Project Find Results even after re-enabling file-icons.
file-icons-icons-removal

Atom    : 1.25.0-dev-b7258bdc8
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0
@winstliu
Copy link
Author

winstliu commented Dec 9, 2017

Upon further investigation, icons will come back for Find and Replace once you start scrolling presumably because of its dynamic element addition and removal.

@Alhadis
Copy link
Member

Alhadis commented Feb 22, 2018

Sorry for not looking into these issues (as well as unburdening package load time by making it asynchronous). 😞 I wanted to tackle them with a temporary solution at least, but I had to get v2.1.17 cut.

@Alhadis Alhadis added the bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. label Oct 15, 2018
@Alhadis Alhadis added this to the v2.2.0 milestone Oct 15, 2018
@Alhadis Alhadis self-assigned this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed defect in package logic, deprecation notices, and PRs which fix them.
Projects
None yet
Development

No branches or pull requests

2 participants