Random CoffeeScript file showing up as Appveyor #563

winstliu · 2017-03-20T21:58:10Z

The tab icon when you open it is the Coffeescript brown + the Appveyor icon. Switching languages does not help.

Alhadis · 2017-03-20T22:43:41Z

Right, kick devtools open. Run this:

_FileIcons.fs.paths

Tell me if:

Any paths are using backwards delimiters
Any entries are keyed with values that aren't Directory or File instances
If more than one key exists for a path (...somehow)

Next:

const fubar = _FileIcons.grep("git-repository-spec.coffee");

Show me the contents of:

fubar.icons
fubar.currentIcon

winstliu · 2017-03-20T22:59:01Z

The path for C:\Users\user\Documents\GitHub\atom\spec\git-repository-spec.coffee is pointing to uh... C:/Users/user/Documents/GitHub/atom/appveyor.yml...

The two properties are undefined.

Alhadis · 2017-03-20T23:04:19Z

2017 and Microsoft still insist on using relics of the DOS-era. Christ, I hate those separators...

Right, that's made the catalyst pretty clear. What I can't understand is how it fell through the dozens of normalisePath calls I scattered everywhere to make sure no backwards/weird-Windows paths were used as keys. *sigh*

Thankfully, stuff like this is about to become easier to debug. Almost finished decoupling the filesystem API... -_-

Guess there's nothing insightful in _FileIcons.log?

winstliu · 2017-03-20T23:50:02Z

Oh, all my keys were Windows-style. Their corresponding File was mapped to a Unix-style path though. Is that worrisome?

EDIT: As for _FileIcons.log, there's ~400 entries in there. Sorting through them might take a while to find the correct one.

EDIT2: Found it. The path again is appveyor.yml instead of git-repository-spec.coffee.

Alhadis · 2017-03-21T00:04:05Z

Quite the opposite. To make my life simpler and less prickly, I force Windows paths to use POSIX path separators. Every path is meant to be normalised this way before lookup. Obviously something slipped through the gaps somewhere, because those keys aren't meant to be delimited like that.

Is your process.platform global set to "win32"...?

winstliu · 2017-03-21T00:13:00Z

process.platform
"win32"

Alhadis · 2017-03-21T00:16:19Z

The separator discrepancies are the reason for this schizophrenic mess. If I can plug that, this issue will likely be resolved. Needless to say, this is probably connected to the original issue you filed.

I should also check the latest beta to see if there's anything broken I need to fix... -_-

Alhadis · 2017-03-21T16:47:00Z

BTW, improved path-handling will need to wait for another release. I didn't wanna hold off publishing v2.0.0, but I didn't want to rush anything either.

Which overlooks the fact I just spent several hours mud-wrestling both NPM and APM to get these versions published, but yeah.

winstliu · 2017-03-21T16:51:13Z

Just updated to 2.1.1 and I ❤️ the new test icons though :).

Alhadis · 2017-03-21T16:52:18Z

Glad to hear that, haha. Spent hours designing 'em. :)

It's interesting how difficult icons are to design well... so little room, so many details can get lost so easily...

winstliu · 2017-09-23T18:27:07Z

@Alhadis is this maybe the same issue that I'm seeing right now?

This is on the freshly-cloned language-csharp repo.

Alhadis · 2017-09-23T18:30:23Z

Freshly-cloned? As in, you didn't create new directories or rename files in the tree-view after seeing this?

Have you cloned this repo to its current directory before...?

winstliu · 2017-09-23T18:32:17Z

As in, you didn't create new directories or rename files in the tree-view after seeing this?

Nope.

Have you cloned this repo to its current directory before...?

Maybe a long time ago. I have not recently cloned this repo.

Here's the full tree: you can see it happening twice.

winstliu · 2017-09-23T18:34:24Z

Introducing: I have no idea what is going on. This is from a new Atom window (atom . -n).

Alhadis · 2017-09-23T18:36:31Z

Could you show the output of apm ls -bi, please? I'm gonna have a look at this from a virtualised Windows environment, since I've been unable to reproduce this on Darwin.

winstliu · 2017-09-23T18:38:32Z

This isn't going to be of much help because the majority of the packages are linked, but here you go.

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

autocomplete-python, busy-signal, linter, linter-ui-default, MagicPython are disabled.

Alhadis · 2017-09-23T18:50:51Z

When you run AtomFS.paths in the dev-console, and expand the entries list... are the path separators uniform across all entries? Or do some still have backslashes as separators? They should all be forwards-facing...

winstliu · 2017-09-23T19:00:05Z

Oh hey, look at this. Want me to file a new issue? Only happened in Window 1 (which is in dev mode).

Uncaught (in promise) TypeError: entity.addEditor is not a function
    at disposables.add.onOpenFile.editor (C:\Users\user\.atom\packages\file-icons\lib\ui.js:39:12)
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\user\Documents\GitHub\atom\node_modules\event-kit\lib\emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (C:\Users\user\Documents\GitHub\atom\node_modules\event-kit\lib\emitter.js:141:28)
    at disposables.add.atom.workspace.observeTextEditors.editor (C:\Users\user\.atom\packages\file-icons\lib\ui.js:66:19)
    at file:///C:/Users/user/Documents/GitHub/atom/out/app/src/workspace.js:621:54
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\user\Documents\GitHub\atom\node_modules\event-kit\lib\emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (C:\Users\user\Documents\GitHub\atom\node_modules\event-kit\lib\emitter.js:141:28)
    at file:///C:/Users/user/Documents/GitHub/atom/out/app/src/workspace.js:502:22
    at file:///C:/Users/user/Documents/GitHub/atom/out/app/src/workspace.js:502:82
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\user\Documents\GitHub\atom\node_modules\event-kit\lib\emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (C:\Users\user\Documents\GitHub\atom\node_modules\event-kit\lib\emitter.js:141:28)
    at PaneContainer.didAddPaneItem (C:\Users\user\Documents\GitHub\atom\src\pane-container.js:266:18)
    at Pane.addItem (C:\Users\user\Documents\GitHub\atom\src\pane.js:628:42)
    at Pane.activateItem (C:\Users\user\Documents\GitHub\atom\src\pane.js:570:12)
    at Workspace.<anonymous> (file:///C:/Users/user/Documents/GitHub/atom/out/app/src/workspace.js:1025:12)
    at Generator.next (<anonymous>)
    at step (file:///C:/Users/user/Documents/GitHub/atom/out/app/src/workspace.js:1:12)

Have a field day with this.

winstliu · 2017-09-23T19:03:00Z

I'm also getting errors from the github package, so maybe it's not just file-icons.

Alhadis · 2017-09-23T19:04:40Z

Are you running a beta version of Atom, or has it been built from master directly?

winstliu · 2017-09-23T19:05:27Z

I'm running Atom 1.22.0-dev-f762bf954. Should have included that, sorry.

Alhadis · 2017-09-23T19:06:48Z

Can you test this in a stable environment, please?

winstliu · 2017-09-23T19:14:22Z

Will try to.

winstliu · 2017-09-27T21:17:33Z

Ok, as this is happening with literally every new repo I'm cloning, I suspect it may be due to my tree-view Map changes. I will attempt to report back soon.

Alhadis · 2017-09-27T21:51:59Z

@50Wliu Don't forget to leverage the filesystem API's index (global.AtomFS.paths) in case it helps you with debugging. :)

I appreciate the time you're putting towards investigating this.

winstliu · 2017-11-09T23:33:10Z

I tried checking out some new repos while on Atom 1.22.0 stable with only file-icons and my syntax theme installed. While I can't reproduce the incorrect icons right now, I can still confirm that AtomFS.paths is reporting a mix of Unix and Windows-style path delimiters. Directories use Unix-style while Files use Windows-style.

language-csharp is still broken and some entries in the Map map to undefined.

Alhadis · 2017-11-20T04:48:19Z

Right, this should be solved with the latest release. Could you confirm?

If not the incorrect icons, then certainly the inconsistent path separators. I've added a speciality class to help deal with that.

winstliu · 2017-12-09T17:22:45Z

Right, this should be solved with the latest release. Could you confirm?

Whoops, missed this. I'll get back to you when I have time.

winstliu · 2017-12-11T19:39:10Z

There is no language-csharp/grammars entry in AtomFS.paths.

I also see this:

The file does exist in AtomFS.paths and points to the correct File. Changing languages does nothing.

Atom 1.25.0-dev-3039ac1f4, [email protected].

Alhadis changed the title ~~Random Coffeescript file showing up as Appveyor~~ Random CoffeeScript file showing up as Appveyor Mar 20, 2017

Alhadis self-assigned this Mar 21, 2017

Alhadis added the bug Confirmed defect in package logic, deprecation notices, and PRs which fix them. label Mar 21, 2017

Alhadis mentioned this issue Mar 22, 2017

Files with the same name sometimes end up with the wrong icon #499

Open

winstliu mentioned this issue Sep 23, 2017

Unable to view unstaged changes atom/github#1188

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Random CoffeeScript file showing up as Appveyor #563

Random CoffeeScript file showing up as Appveyor #563

winstliu commented Mar 20, 2017

Alhadis commented Mar 20, 2017

winstliu commented Mar 20, 2017

Alhadis commented Mar 20, 2017

winstliu commented Mar 20, 2017 •

edited

Loading

Alhadis commented Mar 21, 2017

winstliu commented Mar 21, 2017

Alhadis commented Mar 21, 2017

Alhadis commented Mar 21, 2017

winstliu commented Mar 21, 2017

Alhadis commented Mar 21, 2017

winstliu commented Sep 23, 2017 •

edited

Loading

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

winstliu commented Sep 27, 2017

Alhadis commented Sep 27, 2017

winstliu commented Nov 9, 2017

Alhadis commented Nov 20, 2017

winstliu commented Dec 9, 2017

winstliu commented Dec 11, 2017

Random CoffeeScript file showing up as Appveyor #563

Random CoffeeScript file showing up as Appveyor #563

Comments

winstliu commented Mar 20, 2017

Alhadis commented Mar 20, 2017

winstliu commented Mar 20, 2017

Alhadis commented Mar 20, 2017

winstliu commented Mar 20, 2017 • edited Loading

Alhadis commented Mar 21, 2017

winstliu commented Mar 21, 2017

Alhadis commented Mar 21, 2017

Alhadis commented Mar 21, 2017

winstliu commented Mar 21, 2017

Alhadis commented Mar 21, 2017

winstliu commented Sep 23, 2017 • edited Loading

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

Alhadis commented Sep 23, 2017

winstliu commented Sep 23, 2017

winstliu commented Sep 27, 2017

Alhadis commented Sep 27, 2017

winstliu commented Nov 9, 2017

Alhadis commented Nov 20, 2017

winstliu commented Dec 9, 2017

winstliu commented Dec 11, 2017

winstliu commented Mar 20, 2017 •

edited

Loading

winstliu commented Sep 23, 2017 •

edited

Loading