Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency paths longer than 2 nodes unsupported? #75

Closed
rulatir opened this issue Dec 9, 2019 · 3 comments · May be fixed by #76
Closed

Dependency paths longer than 2 nodes unsupported? #75

rulatir opened this issue Dec 9, 2019 · 3 comments · May be fixed by #76
Labels
Bug

Comments

@rulatir
Copy link

rulatir commented Dec 9, 2019 •
edited
Loading

Steps to reproduce (note two consecutive invocations of biomake):

git clone https://github.com/rulatir/biomake-bug-demo.git
cd biomake-bug-demo
biomake -H
biomake -H

Expected result:

build/indirectly-dependent should contain the same random data as build/random64 because:

  • the former has the latter as a dependency
  • the former is built simply by copying the latter

Actual result:

build/indirectly-dependent contains stale data from when it was created as a result of the first invocation of biomake.

Output of second invocation:

Warning: could not update MD5 file for FORCE <-- []
  dd count=1 if=/dev/urandom of=build/randomstuff
1+0 records in
1+0 records out
512 bytes copied, 0.000138352 s, 3.7 MB/s
 base64 < build/randomstuff > build/random64
build/indirectly-dependent is up to date

The claim that build/indirectly-dependent is up to date is patently false. Its dependency has changed.
@rulatir
Copy link
Author

rulatir commented Dec 13, 2019 •
edited
Loading

BOOMP? If only Prolog weren't completely paradigmatically alien to me then I would just fork and fix. But it is, and I must rely on hoping to get authors' attention instead ...

cmungall added a commit that referenced this issue Dec 15, 2019
@cmungall
Ensure that database value of md5 is retracted when re-calculating hash.
ac7216b 
Fixes #75
However, causes md5.time test to fail
@cmungall cmungall mentioned this issue Dec 15, 2019
Open
@cmungall
Copy link
Member

Apologies for the delay, I have a fix that unfortunately causes one of the tests to fail, will look into this later, but for now you could try this branch: https://github.com/evoldoers/biomake/tree/issue-75

@ihh ihh added the Bug label Dec 19, 2019
@ihh
Copy link
Member

ihh commented May 29, 2020

@cmungall could you add a test to your PR that includes the bug that this fixes. I will look at the test that now fails.

@ihh ihh closed this as completed in 14769f7 May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that database value of md5 is retracted when re-calculating hash. evoldoers/biomake
3 participants
@cmungall @ihh @rulatir