Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVMC versioning is incompatible with the "EIP-centric hard forks" model #453

Open
axic opened this issue Nov 13, 2019 · 3 comments
Open

Comments

@axic
Copy link
Member

axic commented Nov 13, 2019

See https://ethereum-magicians.org/t/eip-centric-forking/3536.

It requires EIPs to be implemented in clients and be switched on independently. They are only later assigned to a hard fork.

I am not sure what is the best course of action for EVMC.

@axic
Copy link
Member Author

axic commented Nov 13, 2019

cc @chfast @chriseth

@chfast
Copy link
Member

chfast commented Nov 13, 2019

Extend the EVM revision type.

struct evmc_revision_ex 
{
    evmc_revision rev;
    uint32_t extensions;
};

@axic
Copy link
Member Author

axic commented Nov 13, 2019

Do you mean that rev is the base revision on top extensions are enabled and the extension flags are specific to the revision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants