Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script errors should include proper tracebacks #797

Open
luxaritas opened this issue Aug 9, 2024 · 0 comments
Open

Script errors should include proper tracebacks #797

luxaritas opened this issue Aug 9, 2024 · 0 comments
Labels
priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact size: sm type: enhancement New feature or request

Comments

@luxaritas
Copy link
Member

Describe your idea

Currently, if a SCRIPT constraint or booster (for anything run synchronously, after #794) errors, the traceback only includes EternaJS code, not information about where it failed in the script. We should be providing a traceback within the script

Motivation

This would allow script authors to better debug errors in their scripts

Proposed Solution

Instead of just returning a caught error's cause in the script interface evaluate method, we should also return the entire error object - which, presumably, we can and should simply rethrow (if we're throwing anyways) or otherwise access the stacktrace.

Note that we will need to deal with the lack of cache bust first since this requires a change to the script-interface script (see #795)

Other Information

No response

@luxaritas luxaritas added type: enhancement New feature or request size: sm priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact size: sm type: enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant