Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use net.JoinHostPort #4599

Merged
merged 3 commits into from
Nov 1, 2024
Merged

chore: use net.JoinHostPort #4599

merged 3 commits into from
Nov 1, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Oct 31, 2024

fixes: #4597

@zirain zirain requested a review from a team as a code owner October 31, 2024 22:36
arkodg
arkodg previously approved these changes Oct 31, 2024
@arkodg arkodg requested review from a team October 31, 2024 22:39
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.42%. Comparing base (db68027) to head (9ac2399).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/securitypolicy.go 80.00% 1 Missing ⚠️
internal/kubernetes/port_forwarder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4599      +/-   ##
==========================================
+ Coverage   65.40%   65.42%   +0.01%     
==========================================
  Files         211      211              
  Lines       31887    31887              
==========================================
+ Hits        20855    20861       +6     
+ Misses       9785     9781       -4     
+ Partials     1247     1245       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zirain <[email protected]>
@zirain zirain merged commit 6e2587d into envoyproxy:main Nov 1, 2024
24 checks passed
@zirain zirain deleted the JoinHostPort branch November 1, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6: use net.JoinHostPort
4 participants