-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/v1.1] bump envoy #4596
base: release/v1.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
@guydc
|
0605c23
to
40ca926
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.1 #4596 +/- ##
================================================
- Coverage 66.63% 66.61% -0.02%
================================================
Files 183 183
Lines 28112 28112
================================================
- Hits 18732 18727 -5
- Misses 8294 8298 +4
- Partials 1086 1087 +1 ☔ View full report in Codecov by Sentry. |
all the GRPCRoute tests are failing, does the build work with https://gateway.envoyproxy.io/docs/tasks/traffic/grpc-routing/ , if it doesnt we should report this upstream and imo release without the patch release |
Signed-off-by: Guy Daich <[email protected]>
40ca926
to
963e38f
Compare
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No