Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.1] bump envoy #4596

Open
wants to merge 1 commit into
base: release/v1.1
Choose a base branch
from

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Oct 31, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@guydc guydc requested a review from a team as a code owner October 31, 2024 21:26
arkodg
arkodg previously approved these changes Oct 31, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg
Copy link
Contributor

arkodg commented Oct 31, 2024

@guydc
looks like another change is needed

+++ b/examples/extension-server/go.mod
@@ -10,7 +10,7 @@ require (
 	google.golang.org/protobuf v1.34.2
 	k8s.io/apimachinery v0.30.2
 	sigs.k8s.io/controller-runtime v0.18.4
-	sigs.k8s.io/gateway-api v1.1.0
+	sigs.k8s.io/gateway-api v1.1.1
 )

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.61%. Comparing base (13fee13) to head (963e38f).

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.1    #4596      +/-   ##
================================================
- Coverage         66.63%   66.61%   -0.02%     
================================================
  Files               183      183              
  Lines             28112    28112              
================================================
- Hits              18732    18727       -5     
- Misses             8294     8298       +4     
- Partials           1086     1087       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Oct 31, 2024
@arkodg arkodg changed the title bump envoy and gw-api [release/v1.1] bump envoy and gw-api Oct 31, 2024
@arkodg
Copy link
Contributor

arkodg commented Nov 1, 2024

all the GRPCRoute tests are failing, does the build work with https://gateway.envoyproxy.io/docs/tasks/traffic/grpc-routing/ , if it doesnt we should report this upstream and imo release without the patch release

zhaohuabing
zhaohuabing previously approved these changes Nov 1, 2024
Signed-off-by: Guy Daich <[email protected]>
@guydc guydc dismissed stale reviews from zhaohuabing and arkodg via 963e38f November 1, 2024 12:04
@guydc guydc changed the title [release/v1.1] bump envoy and gw-api [release/v1.1] bump envoy Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants