Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint passive mode #509

Closed
teamon opened this issue Dec 17, 2021 · 3 comments · Fixed by #591
Closed

Mint passive mode #509

teamon opened this issue Dec 17, 2021 · 3 comments · Fixed by #591
Assignees
Labels
feature ✨ mint Issues related to mint adapter

Comments

@teamon
Copy link
Member

teamon commented Dec 17, 2021

@teamon teamon added help wanted mint Issues related to mint adapter labels Dec 17, 2021
@teamon teamon pinned this issue Dec 17, 2021
@fbergero
Copy link

fbergero commented May 6, 2022

@teamon I'd like to tackle this one

@teamon teamon unpinned this issue May 8, 2022
@fbergero
Copy link

fbergero commented May 8, 2022

@teamon We basically want to change the default active mode to passive here https://github.com/elixir-tesla/tesla/blob/master/lib/tesla/adapter/mint.ex#L51 right?

Doing that only breaks some tests about how passive mode returns timeout. I'll fix those but can't think of any other test to add for this feature.

@teamon
Copy link
Member Author

teamon commented May 9, 2022

Basically yes :)

In case of tests it would be great to have failing test cases for all related issues and then check if changing to passive mode fixes them.

@yordis yordis linked a pull request May 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ mint Issues related to mint adapter
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants