Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Last word of each line can jerk to the next line during animation in TypeAnimationTextView #4869

Open
bemusementpark opened this issue Aug 7, 2024 · 1 comment
Open

[Bug] Last word of each line can jerk to the next line during animation in TypeAnimationTextView #4869

bemusementpark opened this issue Aug 7, 2024 · 1 comment
Labels
bug needs triage

Comments

@bemusementpark
Copy link
Contributor

bemusementpark commented Aug 7, 2024 •
edited
Loading

Describe the bug

During the onboarding animation

Screen_recording_20240807_211447.webm

How to Reproduce

  1. Delete the app or clear app storage
  2. Open the app
  3. Observe text on onboarding screens will sometimes jerk to the next line if a word becomes too long.

This is in contrast to DDG iOS which

Expected behavior

Although it is expected behaviour when you are actually typing, it looks glitchy in an animation, especially a fast one.

I would expect Android to behave as iOS does where each letter is progressively revealed in its right place.

Environment

- DDG App Version: commit ea0bb89a9acc17d7d547997a186725cb8cfb8486 HEAD -> develop, tag: 5.210.2.2-nightly
- Device: API 35
- OS: Android w/Playstore
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Thank you for opening an Issue in our Repository.
The issue has been forwarded to the team and we'll follow up as soon as we have time to investigate.
As stated in our Contribution Guidelines, requests for feedback should be addressed via the Feedback section in the Android app.

@bemusementpark bemusementpark mentioned this issue Aug 7, 2024
Merged
marcosholgado pushed a commit that referenced this issue Sep 18, 2024
@bemusementpark
Fix text glitches to new line in TypeAnimationTextView (#4874)
4f73a17 
Task: https://app.asana.com/0/1125189844152671/1208000645162922/f

Issue URL: #4869

### Description

There is a typing animation that adds each letter to the screen
sequentially. The last word of each line can jerk to the next line if
the word is long enough. On iOS the equivalent animation keeps
characters in position as they are revealed. On Android this animation
is more akin to what you would see when you are actually typing and you
type a long word at the end of a line. The word jerks to the next line.
This is fine when you are typing. But at speed an in an animation it
does not look good. This PR copies iOS style, and applies 100%
transparency to all letters that have not yet been "typed" in the
animation.

### Steps to test this PR

1. Install a fresh copy of the app
2. Do onboarding

_Feature 1_
- [ Change TypeAnimationTextView to progressively reveal each character
rather than progressively adding each character to the output sting ]

### UI changes

Before


[Screen_recording_20240807_211447.webm](https://github.com/user-attachments/assets/8e619a1f-5cc1-46ac-8080-e0d940aa3ed4)

After


[Screen_recording_20240808_021820.webm](https://github.com/user-attachments/assets/f49489f0-404e-41eb-af94-09f0bade0c9a)

---------

Co-authored-by: bemusementpark <bemusementpark>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bemusementpark