-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of modifications halfed in JACUSA 2.0 vs. 1.3 (mode call-2) #47
Comments
Do you mind sharing your "filtered files" The underlying computation and default parametes of some filters have changed. |
Yes, can I send them here: michael.piechotta (at) informatik.hu-berlin.de? I do not want to make these public. |
Yes, BUT please replace the last part with "at gmail.com". |
I just sent it. The attachment is 17MB zipped, so I hope gmail can deal with that. |
I did some more digging: when looking only at the ~360k variants "lost" in Jacusa 2.0 when comparing vs. Jacusa 1.3 it comes all down to the strand.
I then checked all variants for the strand.
It lookes to me like Jacusa 1.3 simply had a bug that did skip certain filters for minus-strand variants. |
Hello, is it a bug of JACUSA 1.3? @piechottam |
We generally recommend using JACUSA2. JACUSA1.x has been deprecated and won't be receiving any updates. |
Thanks for your quick reply. Got it now. |
I noticed that the number of modifications was more than twice as high in 1.3 when compared to 2.0. Both were run on the same BAM files with equivalent parameters.
1.3.0:
call-2 -a D,M,Y --filterNM_1 5 --filterNM_2 5 -s -c 2 -T 1 -P FR-SECONDSTRAND,FR-SECONDSTRAND -p 16 -r hypertribe/jacusa/jacusa_ht_vs_m3d-ht.org ./star_ht_1/igv/ht_1.bam,./star_ht_2/igv/ht_2.bam,./star_ht_3/igv/ht_3.bam,./star_ht_4/igv/ht_4.bam ./star_m3d-ht_1/igv/m3d-ht_1.bam,./star_m3d-ht_2/igv/m3d-ht_2.bam,./star_m3d-ht_3/igv/m3d-ht_3.bam,./star_m3d-ht_4/igv/m3d-ht_4.bam
mods: 537341
2.0.1:
call-2 -a D,M,Y -filterNM 5 -s -c 2 -T 1 -P FR-SECONDSTRAND -p 16 -r hypertribe/jacusa/jacusa_ht_vs_m3d-ht.org ./star_ht_1/igv/ht_1.bam,./star_ht_2/igv/ht_2.bam,./star_ht_3/igv/ht_3.bam,./star_ht_4/igv/ht_4.bam ./star_m3d-ht_1/igv/m3d-ht_1.bam,./star_m3d-ht_2/igv/m3d-ht_2.bam,./star_m3d-ht_3/igv/m3d-ht_3.bam,./star_m3d-ht_4/igv/m3d-ht_4.bam
mods: 201810
This is before any downstream filtering. The changelog found here (https://github.com/dieterich-lab/JACUSA2) does not seem to explain that change. Most of the "lost" modifications have low ratios of modification (e.g. A 22, G 1). Is there a new filter that is not documented yet? Or did I just miss it?
The text was updated successfully, but these errors were encountered: