Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate population of roles section #8

Open
grudelsud opened this issue Feb 13, 2019 · 4 comments
Open

automate population of roles section #8

grudelsud opened this issue Feb 13, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@grudelsud
Copy link
Member

presently to approve a submission you need to be an admin

an admin is defined in the roles collection with a document identified by user id and a field admin: true

values in the roles collection are added manually using the firebase console, there should be a way to do it from the website (e.g. if you are an admin, a button "make admin" is available in the members list page)

@grudelsud grudelsud added the enhancement New feature or request label Apr 27, 2019
@silviopaganini silviopaganini self-assigned this May 15, 2019
@silviopaganini
Copy link
Member

revisiting this

wouldn't it be easier if the Member collection had a admin: true instead?

@grudelsud
Copy link
Member Author

no, that wouldn't work. The problem is that you would give every user the permission to set themselves as admins.

@silviopaganini
Copy link
Member

only if they had access to the DB on firebase... ?

@grudelsud
Copy link
Member Author

they do have access to the database, as they can change their own data. this is the relevant rule: https://github.com/devcon-london/website/blob/master/firestore.rules#L18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants