From e87f37b21f142d88628a72813ab8d4a4c35ed132 Mon Sep 17 00:00:00 2001 From: Christian Monch Date: Tue, 2 Jul 2024 12:16:09 +0200 Subject: [PATCH] fix(tests): check for proper code on Windows This commit extends the return code check in `test_returncode_available_from_generator_with_exception` to include the return code from termination on a Windows system. This commit should fix issue #32 --- .../iterable_subprocess/test_iterable_subprocess.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/datasalad/iterable_subprocess/test_iterable_subprocess.py b/datasalad/iterable_subprocess/test_iterable_subprocess.py index d552530..c61e830 100644 --- a/datasalad/iterable_subprocess/test_iterable_subprocess.py +++ b/datasalad/iterable_subprocess/test_iterable_subprocess.py @@ -415,10 +415,11 @@ def test_returncode_available_from_generator_with_exception(): while True: next(echo) # On a Linux system, all exceptions that are raised before the subprocess - # exited will lead to a -15 return code. If StopIteration is raised, the + # exited will lead to a -15 return code. On a Windows system, exceptions + # will lead to a 1 return code. If StopIteration is raised, the # subprocess will either have terminated which results in a 0-return code, # or the subprocess is still running and will therefore be terminated which - # results in a -15 return code. Any other exception than StopIteration, - # e.g. a CommandError because echo could not be found, would lead to an - # early test-exit and not proceed to the assign-statement. - assert echo.returncode in (0, -15) + # results in a -15 or a 1 return code. Any other exception than + # StopIteration, e.g. a CommandError because echo could not be found, would + # lead to an early test-exit and not proceed to the assign-statement. + assert echo.returncode in (0, 1, -15)