Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL-based tab navigation #381

Closed
jsheunis opened this issue Oct 6, 2023 · 1 comment
Closed

Fix URL-based tab navigation #381

jsheunis opened this issue Oct 6, 2023 · 1 comment

Comments

@jsheunis
Copy link
Member

jsheunis commented Oct 6, 2023

See sfb1451/metadata-catalog#50 (review)

Fix:

Looks like a simple capitalisation issue. The tab_param here https://github.com/datalad/datalad-catalog/blob/main/datalad_catalog/catalog/assets/app_component_dataset.js#L514 needs to be changed to tab_param.toLowerCase()

@jsheunis
Copy link
Member Author

Fixed in a82cc77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant