Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some version numbers appear twice with different results #10

Open
andk opened this issue Jul 6, 2017 · 2 comments
Open

Some version numbers appear twice with different results #10

andk opened this issue Jul 6, 2017 · 2 comments
Labels

Comments

@andk
Copy link

andk commented Jul 6, 2017

http://beta.cpantesters.org/chart.html?dist=Module-Metadata-CoreList

I see the results in this order:

    1.03
    1.03 (smaller number)
    1.04
    1.04 (smaller number)
    1.05
    1.05 (smaller number, probably zero)
    1.06
    1.06 (smaller number)
    1.07
    1.08

Expected: no duplicate bars

@preaction
Copy link
Member

At a quick glance it seems like the chart app is getting the data like that. There are multiple rows in the data for each version of the dist:

[{
    "dist": "Module-Metadata-CoreList",
    "fail": 0,
    "na": 0,
    "pass": 202,
    "unknown": 0,
    "version": "1.00"
}, {
    "dist": "Module-Metadata-CoreList",
    "fail": 0,
    "na": 0,
    "pass": 1,
    "unknown": 0,
    "version": "1.00"
}, {
    "dist": "Module-Metadata-CoreList",
    "fail": 68,
    "na": 2,
    "pass": 3,
    "unknown": 1,
    "version": "1.01"
}, {
    "dist": "Module-Metadata-CoreList",
    "fail": 1,
    "na": 0,
    "pass": 0,
    "unknown": 0,
    "version": "1.01"
}]

So I'll likely need to start by checking the database to see why the data looks like this, and then add some code in either cpantesters-schema or cpantesters-api to filter it out / combine the rows into sums (whichever is correct for the data). This could even be pointing to a larger problem with this data, but my guess is that it's the difference between reports for a "stable" Perl and reports for a "devel" Perl.

@preaction preaction added the bug label Nov 3, 2017
@preaction
Copy link
Member

The releases data at the top is now correctly showing only data from stable Perls, but the test report list at the bottom is showing data from all Perls, which makes for a confusing experience: At the time of this comment, version 1.09 of Module-Metadata-CoreList claims to have 97 PASS reports in the top bar chart, but clicking on 1.09 shows 390 total reports (http://beta.cpantesters.org/chart.html?dist=Module-Metadata-CoreList&version=1.09).

This is because the test summary API does not allow filtering by Perl maturity. We need to add this to the API (cpan-testers/cpantesters-api#24), but before we do that, we need to fix the generation of Perl version metadata (cpan-testers/cpantesters-backend#7).

preaction added a commit that referenced this issue Apr 22, 2018
We need to fix the list of stable/devel Perls in the database, but we
should still be doing this

Refs #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants