Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should minimization failures be better signposted? #27

Open
JasonGross opened this issue Sep 2, 2023 · 2 comments
Open

Should minimization failures be better signposted? #27

JasonGross opened this issue Sep 2, 2023 · 2 comments
Labels
question Further information is requested

Comments

@JasonGross
Copy link
Member

We got feedback (from @herbelin ?)

  • Could it be indicated in the github comment posting the minimizations whether the minimization relies on external files, and, if easy to know, on which?

We already include this information, for example this comment says:

Partially Minimized Coq File (could not inline Equations.Prop.DepElim)

and the fifth line of the comment header in the tfile says:

Modules that could not be inlined: Equations.Prop.DepElim

By contrast, complete minimization says:

Minimized Coq File (consider adding this file to the test-suite)

Should this information be flagged more loudly somehow?

@JasonGross JasonGross added the question Further information is requested label Sep 2, 2023
@Zimmi48
Copy link
Member

Zimmi48 commented Sep 3, 2023

Should this information be flagged more loudly somehow?

The bot could for instance say in one case: "I managed to produce a reduced and fully standalone test case."
And in the other: "I didn't manage to produce a fully standalone test case. Here are the modules that I did not manage to inline: ... Here is the partially minimized file: ..."

@herbelin
Copy link

herbelin commented Sep 3, 2023

As you like. From my point of view, I think it is ok as it is currently (now that I know how to interpret the information).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants