Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colcon more restrictive on project names than CMake #125

Open
Aposhian opened this issue Nov 28, 2022 · 0 comments
Open

colcon more restrictive on project names than CMake #125

Aposhian opened this issue Nov 28, 2022 · 0 comments

Comments

@Aposhian
Copy link

Is there a reason why colcon will only accept project names that have alphanumerics, dashes and underscores?

https://github.com/colcon/colcon-cmake/blob/master/colcon_cmake/package_identification/cmake.py#L165

I agree that in an ideal world, that would be a nice naming convention, but in reality some projects do not conform to that because CMake doesn't make them. Examples:

Can we make the regex more lax, without breaking other things in colcon? The fallback behavior to the directory name is good, but it shouldn't happen when there is a valid CMake project name specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant